Nova V5 #187
Open
Nova V5 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crynobone
reviewed
Jan 14, 2025
| <select-control | ||
| size="xxs" | ||
| @change="handleFilterChanged" | ||
| :selected="advanceFilterSelected" |
There was a problem hiding this comment.
We moved to v-model and defineModel() on Nova 5, so I'm unsure if :selected does anything here.
crynobone
reviewed
Jan 26, 2025
Comment on lines
+24
to
+25
| @change="handleFilterChanged" | ||
| :selected="advanceFilterSelected" |
There was a problem hiding this comment.
Suggested change
| @change="handleFilterChanged" | |
| :selected="advanceFilterSelected" | |
| @selected="handleFilterChanged" | |
| :v-model="advanceFilterSelected" |
crynobone
reviewed
Jan 26, 2025
Comment on lines
+130
to
+131
| handleFilterChanged(value) { | ||
| this.advanceFilterSelected = value; |
There was a problem hiding this comment.
Suggested change
| handleFilterChanged(value) { | |
| this.advanceFilterSelected = value; | |
| handleFilterChanged(value) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor UI fixes to make the cards look the same. Otherwise no breaking changes in Nova.