Remove CPP coverage target from default coverage target #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
approved these changes
Dec 23, 2024
brian-jarvis-aws
approved these changes
Dec 23, 2024
Mainly, we want to remove this to unblock our CI. This task is currently breaking all Mac CI dimensions (and possibly others). The root cause seems related to some mismatches in the related software dependencies used to create the coverage report. More broadly, this coverage report is not in a state of good health and should not bere-introduced to the CI until we take the time addressing these issues: Redundant unit test execution due to dependency hierarchy, ignored errors in the coverage report resulting in poor coverage of the coverage data, surfacing the coverage reporting in a useful manner.
WillChilds-Klein
pushed a commit
to WillChilds-Klein/amazon-corretto-crypto-provider
that referenced
this pull request
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
ACCP-120
Description of changes:
Mainly, we want to remove this to unblock our CI. This task is currently
breaking all Mac CI dimensions (and possibly others). The root cause
seems related to some mismatches in the related software dependencies
used to create the coverage report.
More broadly, this coverage report is not in a state of good health and
should not bere-introduced to the CI until we take the time addressing
these issues: Redundant unit test execution due to dependency hierarchy,
ignored errors in the coverage report resulting in poor coverage of the
coverage data, surfacing the coverage reporting in a useful manner.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.