Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid continuous forking and added FIGlet rendering using a custom font #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MIvanchev
Copy link

Hey @coryfklein, I propose the following changes which avoids forking sleep & date 30 times per second and in fact doesn't use sleep and date at all. I also added an option to support FIGlet rendering with a fancy font I created for the stopwatch. You can use it through sw -f stopwatch.flf. The problem is that the set of changes introduces a dependency on Bash 5.0 because this is when EPOCHREALTIME was introduced.

My intention is to turn sw into the standard *nix CLI stopwatch tool because there is currently no alternative. This would require creating a well-formed package including for example a man page..

@MIvanchev MIvanchev force-pushed the figlet-rendering-no-forking branch from be29f4f to 9eb3aaa Compare January 22, 2024 15:29
@coryfklein
Copy link
Owner

Hey @MIvanchev ! Thanks for submitting this PR. I appreciate your interest in contributing to sw. I currently don't have the time for any meaningful development on the tool, so I've added you as a collaborator. As a test to make sure I did it correctly, go ahead and merge this PR yourself; let me know if that doesn't work and I can try to tweak the permissions. Feel free to add whatever you see fit to sw.

@coryfklein coryfklein closed this Jul 30, 2024
@coryfklein
Copy link
Owner

Closing from inactivity. Happy to reopen later.

@MIvanchev
Copy link
Author

Terribly sorry @coryfklein, I have missed the messages due to bad email filtering, let me get back to you ASAP. I'm really very sorry.

@coryfklein
Copy link
Owner

No worries! I'll reopen it and you can merge it when you're ready.

@coryfklein coryfklein reopened this Jul 30, 2024
@MIvanchev
Copy link
Author

Right, I'm just surprised how this could've happen, I usually answer within minutes 🥲

@coryfklein
Copy link
Owner

Hah well then you're far ahead of me. I only just got my Github notifications correctly configured such that I will even know when folks submit PRs on this repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants