fix: windows support for cca #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zetazzz
reviewed
Sep 10, 2024
| @@ -166,7 +166,7 @@ export const createGitApp = (repo: string, version: string) => { | |||
|
|
|||
|
|
|||
| // Construct the file path | |||
| const relativeFilePath = templateFile.split(join(folderName, template) + sep)[1]; | |||
| const relativeFilePath = templateFile.split((join(folderName, template) + '/').replace(/\\/g,'/'))[1]; | |||
There was a problem hiding this comment.
Add this to the util and use it everywhere please
const posixPath = require('path').posix;
function toPosixPath(mixedPath) {
return mixedPath.replace(/\/g, posixPath.sep);
}
Zetazzz
reviewed
Sep 10, 2024
| @@ -196,7 +196,7 @@ export const createGitApp = (repo: string, version: string) => { | |||
| const closestPkgJson = [] | |||
| .concat(glob(join(currentDirectory, name, '**', 'package.json'))) | |||
| .reduce((shortest, current) => { | |||
| return current.split(sep).length < shortest.split(sep).length ? current : shortest; | |||
There was a problem hiding this comment.
Make sure to use the constant sep from 'const posixPath = require('path').posix;'
pyramation
reviewed
Sep 10, 2024
| @@ -130,3 +131,7 @@ export const getPackageLicAndAccessInfo = async (results) => { | |||
| }; | |||
| } | |||
|
|
|||
| export const glob = (input) => { | |||
| return globSync(input.replace(/\\/g,'/')); | |||
There was a problem hiding this comment.
let's put a comment here — something about windows support.
NorOldBurden
force-pushed
the
fix/windows-support
branch
4 times, most recently
from
035954c to
2c6eae2
Compare
NorOldBurden
force-pushed
the
fix/windows-support
branch
from
2c6eae2 to
c10edda
Compare
NorOldBurden
force-pushed
the
fix/windows-support
branch
from
c10edda to
a314693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.