Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo PR for rosdistro-reviewer #24

Closed

Conversation

cottsay
Copy link
Owner

@cottsay cottsay commented Oct 11, 2024

There are a handful of issues with this PR. Ideally, the review automation should give me clear signals that help me quickly discover how to modify my changes so that they can be accepted.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness. This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro. ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package. Please also read the ROS Distro review guidelines which summarizes this release process.

If you'd like to run this tool again to generate a new review for your PR, just re-request review from GitHub Actions.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.


For changes related to rosdep:

  • ✅ New rosdep keys are named appropriately
  • ❌ There are problems with explicitly provided platforms:
    • One or more explicitly provided platforms are no longer supported
    • One or more explicitly provided platforms are not supported by rosdep

For changes related to yamllint:

  • ❌ One or more linter violations were added to YAML files

'*':
pip:
packages: [aioraven] # Should migrate to system package someday
archlinux: [python3-aioraven]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This OS is not supported by rosdep

packages: [aioraven] # Should migrate to system package someday
archlinux: [python3-aioraven]
ubuntu:
bionic: [python3-aioraven]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This release is no longer a supported version of ubuntu

@@ -196,6 +196,10 @@ atlas:
macports: [atlas]
rhel: [atlas-devel]
ubuntu: [libatlas-base-dev]
aunit:
fedora: [aunit-devel]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: wrong indentation: expected 2 but found 4

python3-aioraven:
'*':
pip:
packages: [aioraven] # Should migrate to system package someday

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line does not pass YAML linter checks: too few spaces before comment

Copy link

This PR hasn't been activity in 14 days. If you are still are interested in getting it merged please provide an update. Otherwise it will likely be closed by a rosdistro maintainer following our contributing policy. It's been labeled "stale" for visibility to the maintainers. If this label isn't appropriate, you can ask a maintainer to remove the label and add the 'persistent' label.

@github-actions github-actions bot added the stale label Oct 26, 2024
@cottsay cottsay closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant