CBG-4390: provide cluster UUID at top level endpoint #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
reviewed
Jan 31, 2025
torcolvin
reviewed
Feb 4, 2025
bbrks
requested changes
Feb 6, 2025
rest/admin_api.go
Outdated
| @@ -352,9 +352,14 @@ func (h *handler) handleGetDbConfig() error { | |||
|
|
|||
| type RunTimeServerConfigResponse struct { | |||
| *StartupConfig | |||
| RuntimeClusterUUID | |||
There was a problem hiding this comment.
I'd like to put this in a nested "runtime" struct in the response if possible - somewhere we can add more runtime-only info in future without interfering or being lost inside the actual StartupConfig properties.
I'm thinking of things like post-bootstrap server addresses (since we can bootstrap from a single node and get many servers back), server node latency information, and even non-server runtime info (uptime, command line flags, host timezone, etc.)
There was a problem hiding this comment.
Good shout, updated screenshot in description to reflect the change.
bbrks
approved these changes
Feb 6, 2025
gregns1
added a commit
that referenced
this pull request
Feb 6, 2025
* CBG-4390: provide cluster UUID at top level endpoint * update to fix for non persistent config * fix for rosmar * remove pre paramatised test * nit * move mgtrequest into common function * updates * remove unused code * fix failing test * update to create separate struct of info for runtime only info
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4390
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2940/