CBG-4452 avoid checking revpos on attachments #7382
+21
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this check did not do anything meaningful. - remove TestMinRevPosProveAttachment which had a race condition - switch Blip Tester to only send 20 revs in history
adamcfraser
reviewed
Feb 14, 2025
| } | ||
| } | ||
| // updatedRevPos is the revpos of the new revision, to be added to attachment metadata if needed for CBL<4.0 compatibility. revpos is not used |
There was a problem hiding this comment.
Can we identify which versions of CBL require revpos, if any? I was under the impression that revpos is strictly a SGW concept and shouldn't actually be required for any clients as long as SGW is using 1:1 attachment:document storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4452 avoid checking revpos on attachments
The test failed due to a race between when rev 26-abc was stored on server and when the BlipTesterClient had updated the last known server value of a document.
rt.WaitForVersionwould wait for when the document is stored on Couchbase Server but the last known server revision is stored when therevmessage comes back. It would have been possible to fix this test, but it was testing behavior that currently exists, so decided to remove it.Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2958/