Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DateMethodCallTranslator to better support Date truncation #374

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

gritse
Copy link
Contributor

@gritse gritse commented Aug 7, 2024

We can now use the DateTime.Date and DateTimeOffset.Date properties in LINQ without needing the N1QlFunctions.DateTrunc method. This enhancement makes LINQ expressions cleaner and more consistent with other LINQ providers that already support this behavior.

Copy link
Collaborator

@brantburnett brantburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, it looks good! Just one minor point.

@gritse gritse requested a review from brantburnett August 8, 2024 14:58
@brantburnett brantburnett merged commit 0dd8f30 into couchbaselabs:master Aug 9, 2024
1 check passed
@brantburnett
Copy link
Collaborator

Thanks again for the submission, I merged it and added some additional tests around it.

Is this something that's blocking a project you're working on? @jeffrymorris manages the releases for this repo, not me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants