Coveofoundation #1

vbernard-coveo · 2017-04-07T19:45:48Z

Added CoveoIndexing foundation and CoveoSearch Feature projects and serialized items

I also added some references for the project to build.

Items serialized in CoveoSearch Feature

This reverts commit d9d1106.

This reverts commit 34eb73f.

…to CoveoSearch-Components

jflheureux · 2017-04-10T20:45:03Z

src/Foundation/CoveoIndexing/code/Sitecore.Foundation.CoveoIndexing.csproj

@@ -49,10 +49,31 @@
    <WarningLevel>4</WarningLevel>
  </PropertyGroup>
  <ItemGroup>
+    <Reference Include="Coveo.Framework">
+      <HintPath>..\..\..\..\..\..\inetpub\wwwroot\Habitat.Coveo.Dev.Local\Website\bin\Coveo.Framework.dll</HintPath>


Les références de projet doivent pointer à l'intérieur de projet et non dans le web root. Inclue les fichiers que tu as besoin dans une tâche Gulp. Je crois que Habitat a déjà un script pour ramasser les DLLs de WFFM. S'il n'en a pas, je sais que Sitecore.Demo en a un pour ramasser les DLLs de Habitat.

jflheureux · 2017-04-10T20:46:21Z

src/Foundation/CoveoIndexing/code/Sitecore.Foundation.CoveoIndexing.csproj

@@ -74,6 +95,11 @@
    <None Include="Web.config" />
  </ItemGroup>
  <ItemGroup>
+    <Compile Include="InboundFilters\ExcludeDesignerFiles.cs" />


Certains de ces classes n'ont pas de lien avec Habitat mais ont un lien seulement avec Sitecore.Demo. Il faut les enlever de ce repo et les mettre seulement dans le repo Sitecore.Demo.Coveo qui sera créé plus tard.

jflheureux · 2017-04-10T20:46:45Z

src/Foundation/CoveoIndexing/code/Sitecore.Foundation.CoveoIndexing.csproj

@@ -82,6 +108,7 @@
      <Name>Sitecore.Foundation.SitecoreExtensions</Name>
    </ProjectReference>
  </ItemGroup>
+  <ItemGroup />


Supprime cet itemGroup vide qui a été ajouté.

jflheureux · 2017-04-10T20:47:50Z

src/Foundation/CoveoIndexing/code/Sitecore.Foundation.CoveoIndexing.csproj

@@ -1,12 +1,12 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>


Ton éditeur semble avoir ajouté un BOM au début du fichier. Revert ce changement svp. Et assures-toi de ne pas committer de changements de la sorte dans le futur.

Je comprend pas la diff entre les deux fichier sur cette ligne?

La différence c'est un caractère invisible au début de la ligne. Ce caractère s'appelle le BOM (Byte order mark) et est utilisé dans les fichiers XML. https://en.wikipedia.org/wiki/Byte_order_mark

Ne semble pas corrected selon le diff dans GitHub

Thread done.

jflheureux · 2017-04-10T20:48:21Z

src/Foundation/CoveoIndexing/code/Processors/ResolveItemSiteProcessor.cs

@@ -0,0 +1,155 @@
+// Copyright (c) 2005-2017, Coveo Solutions Inc.


Je pense qu'on peut enlever le copyright car on doit en mettre un différent dans notre repo.

jflheureux · 2017-04-10T20:55:44Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

+    <coveo>
+      <defaultIndexConfiguration>
+        <fieldMap type="Coveo.SearchProvider.CoveoFieldMap, Coveo.SearchProvider">
+          <fieldNames hint="raw:AddFieldByFieldName">


Les fields vont aller avec les projets

J'ai déplacé les fields dans le projet Habitat

jflheureux · 2017-04-10T20:57:08Z

.gitignore

Revert de changement de fin de fichier svp.

jflheureux · 2017-04-10T20:57:41Z

src/Foundation/CoveoIndexing/code/.vs/config/applicationhost.config

@@ -0,0 +1,1028 @@
+<?xml version="1.0" encoding="UTF-8"?>


Ce fichier ne devrait pas être dans le repo. Il devrait être exclus par le gitignore.

jflheureux · 2017-04-10T20:59:05Z

...Feature/CoveoSearch/code/App_Config/Include/Feature/Feature.CoveoSearch.Serialization.config

        <configuration name="Feature.CoveoSearch" dscription="Feature CoveoSearch" dependencies="Foundation.Serialization,Foundation.CoveoIndexing" patch:after="configuration[@name='Foundation.Serialization']">
          <targetDataStore physicalRootPath="$(sourceFolder)\feature\coveosearch\serialization" type="Rainbow.Storage.SerializationFileSystemDataStore, Rainbow" useDataCache="false" singleInstance="true" />
-          <predicate type="Unicorn.Predicates.SerializationPresetPredicate, Unicorn" singleInstance="true">
-          </predicate>
+          <predicate type="Unicorn.Roles.Predicates.EmptyPredicate, Unicorn.Roles" singleInstance="true" />


t'es certain que c'est un EmptyPredicate du namespace Unicorn.Roles qu'on a besoin? Je pensais plus au namespace Unicorn.Predicates si c'est disponible. Car on a déjà des rolePredicates plus bas.

Oui, seulement lorsqu'il n'y a pas d'item a sérializer. C'est un "dummy".

jflheureux · 2017-04-10T21:01:15Z

...veoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.Serialization.config

-          </predicate>
-          <roleDataStore type="Unicorn.Roles.Data.FilesystemRoleDataStore, Unicorn.Roles" physicalRootPath="$(sourceFolder)\foundation\coveoindexing\serialization\Foundation.Indexing.Roles" singleInstance="true"/>
+          <targetDataStore physicalRootPath="$(sourceFolder)\foundation\coveoindexing\serialization" type="Rainbow.Storage.SerializationFileSystemDataStore, Rainbow" useDataCache="false" singleInstance="true" />
+          <predicate type="Unicorn.Roles.Predicates.EmptyPredicate, Unicorn.Roles" singleInstance="true" />


Même commentaire par rapport au namespace

Meme commentaire qu'en haut

Thread done.

Coveosearch components

…ields

jflheureux · 2017-04-11T14:56:50Z

...veoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.Serialization.config

        <configuration name="Foundation.CoveoIndexing" description="Foundation CoveoIndexing" dependencies="Foundation.Serialization" patch:after="configuration[@name='Foundation.Serialization']">
-          <targetDataStore physicalRootPath="$(sourceFolder)\foundation\indexing\serialization" type="Rainbow.Storage.SerializationFileSystemDataStore, Rainbow" useDataCache="false" singleInstance="true" />
-
+          <targetDataStore physicalRootPath="$(sourceFolder)\foundation\coveoindexing\serialization" type="Rainbow.Storage.SerializationFileSystemDataStore, Rainbow" useDataCache="false" singleInstance="true" />


Déplacer dans Projects/Common

jflheureux · 2017-04-11T14:59:28Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

+      <coveoInboundFilterPipeline>
+        <processor type="Sitecore.Foundation.CoveoIndexing.ExcludeVideoFiles, Sitecore.Foundation.CoveoIndexing" />
+        <processor type="Sitecore.Foundation.CoveoIndexing.ExcludeImageFiles, Sitecore.Foundation.CoveoIndexing" />
+        <processor type="Coveo.SearchProvider.CoveoInboundFilters.HasLayoutInboundFilter, Coveo.SearchProviderBase"></processor>


Configurer le processeur pour affecter seulement les items de /sitecore/content mais ne pas toucher la media library.

jflheureux · 2017-04-11T15:00:29Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

+      <defaultIndexConfiguration>
+        <fieldMap type="Coveo.SearchProvider.CoveoFieldMap, Coveo.SearchProvider">
+          <fieldNames hint="raw:AddFieldByFieldName">
+            <fieldType fieldName="metakeywords" isSortable="true" isExternal="true" isMultiValue="true" settingType="Coveo.Framework.Configuration.FieldConfiguration, Coveo.Framework" />


Déplacer dans project/Common

J'ai déplacé dans le project Common

jflheureux · 2017-04-11T15:02:28Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

+        <fieldMap type="Coveo.SearchProvider.CoveoFieldMap, Coveo.SearchProvider">
+          <fieldNames hint="raw:AddFieldByFieldName">
+            <fieldType fieldName="metakeywords" isSortable="true" isExternal="true" isMultiValue="true" settingType="Coveo.Framework.Configuration.FieldConfiguration, Coveo.Framework" />
+            <fieldType fieldName="title" isFacet="true" settingType="Coveo.Framework.Configuration.FieldConfiguration, Coveo.Framework" />


Déplacer dans project/common puisque le champ title doit être défini dans une feature quelconque.

Déplacé dans le projet Common

jflheureux · 2017-04-11T15:04:29Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

+          <externalFields hint="raw:AddExternalField">
+            <field fieldName="syslanguage"/>
+            <field fieldName="sysfiletype"/>
+            <field fieldName="date"/>


Changer pour sysdate.

jflheureux · 2017-04-11T15:06:18Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

+      <contentSearch>
+        <configuration>
+          <indexes hint="list:AddIndex">
+            <index id="Coveo_master_index_Habitat" type="Coveo.SearchProvider.ProviderIndex, Coveo.SearchProvider" patch:before = "*[1]">


Les indexs Habitat vont dans project/habitat

jflheureux · 2017-04-11T15:09:18Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeImageFiles.cs

@@ -0,0 +1,21 @@
+using Coveo.SearchProvider.Pipelines;


Ordonner les using en ordre alphabétique en commençant par les using System.

jflheureux · 2017-04-11T15:09:30Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeVideoFiles.cs

@@ -0,0 +1,21 @@
+using Coveo.SearchProvider.Pipelines;


Ordonner les using en ordre alphabétique en commençant par les using System.

jflheureux · 2017-04-11T15:13:00Z

...on/CoveoIndexing/serialization/Foundation.CoveoIndexing.Facets/CoveoIndexing/ytviewcount.yml

@@ -0,0 +1,31 @@
+---


Les facettes youtube et autres doivent être enlevées de ton pull request. Les facettes utiles doivent être dans Project/common

jflheureux · 2017-04-11T15:14:49Z

src/Project/Habitat/code/App_Config/Include/Project/Habitat.Website.config

@@ -2,6 +2,51 @@

 <configuration xmlns:patch="http://www.sitecore.net/xmlconfig/">
    <sitecore>
+      <contentSearch>


Ce fichier est indenté avec 4 espaces. Assures-toi que tes ajoutes respectent le format du fichier.

…gets packages

…Include original searchbox in home Also recreate orginal search page, and create CoveoSearch page

…de Coveo at the end

…ut sorting and put them back in __Standard values

francoislg

Passé rapidement sur les items, mais there you go!

francoislg · 2017-05-03T13:40:01Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeImageFiles.cs

+            {
+                var extension = args.IndexableToIndex.Item.GetFieldValue("Extension");
+
+                if ((extension == "gif") || (extension == "png") || (extension == "jpg"))


Serait facile de rendre ça configurable dans la config.

francoislg · 2017-05-03T13:40:16Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeImageFiles.cs

+        {
+            if (args.IndexableToIndex != null && !args.IsExcluded && ShouldExecute(args))
+            {
+                var extension = args.IndexableToIndex.Item.GetFieldValue("Extension");


Changer var pour string

francoislg · 2017-05-03T13:41:27Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeVideoFiles.cs

+        {
+            if (args.IndexableToIndex != null && !args.IsExcluded && ShouldExecute(args))
+            {
+                var extension = args.IndexableToIndex.Item.GetFieldValue("Extension");


Je propose de faire un ExcludeFilesWithExtensionTypes qui prends une liste d'extension. Même pas besoin de classe abstraite.

francoislg · 2017-05-03T13:44:51Z

src/Foundation/CoveoIndexing/code/Processors/ResolveItemSiteProcessor.cs

+        /// </summary>
+        /// <param name="p_Item">The item whose site to resolve.</param>
+        /// <returns>The resolved site name, or <c>null</c> when no suitable site is found.</returns>
+        protected virtual string ResolveItemSite(IItem p_Item)


Ça donne rien que cette méthode soit virtual. Rendu là je vais me faire un autre processeur.

C'est une copie d'un processeur existant de Coveo for Sitecore avec un petit tweak pour Habitat.

Thread done.

francoislg · 2017-05-03T13:46:56Z

src/Foundation/CoveoIndexing/code/Processors/ResolveItemSiteProcessor.cs

+        /// <summary>
+        /// Gets the list of sites that are excluded by default.
+        /// </summary>
+        public static IEnumerable<string> DefaultExcludedSites { get; private set; }


Je vois pas beaucoup d'intérêt à mettre ça public.

C'est une copie d'un processeur existant de Coveo for Sitecore avec un petit tweak pour Habitat.

Thread done.

francoislg · 2017-05-03T14:29:34Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitatSearchbox.css

+    border: none;
+}
+
+.CoveoSearchbox{


francoislg · 2017-05-03T14:29:42Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitatSearchbox.css

+    border-bottom: 2px solid white;
+}
+
+.CoveoSearchbox .magic-box .magic-box-input>input {


francoislg · 2017-05-03T14:30:06Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitatSearchbox.css

+    background-color: rgb(240, 240, 240);
+}
+
+.CoveoSearchButton>.coveo-icon,


francoislg · 2017-05-03T14:30:26Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitatSearchbox.css

+    color: #fff;
+}
+
+.CoveoSearchButton{


space, le prochain aussi

francoislg · 2017-05-03T14:32:35Z

...roject/Habitat/serialization/Project.Habitat.Roles/habitat/Project Habitat Modules Admin.yml

@@ -5,9 +5,9 @@ MemberOf:
  Role: |
    modules\Feature Multisite Admin
  Role: |
-    modules\Feature Social Admin


Je vois pas pourquoi l'ordre a changé pour certains, ça serait plus facile de voir les vrais ajouts

Surement pas la même version de Unicorn utilisée pour le sync initial et cette modif. Je suis d'accord avec François. Peux-tu resturer l'ordre (à la main au pire)

Corrected search view and Search boxes

francoislg · 2017-06-20T19:30:48Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+                string itemExtension = args.IndexableToIndex.Item.GetFieldValue("Extension");
+
+                foreach (string extensionType in extensionTypesToExclude) {
+


Pas mal d'espaces de trop dans cette classe-là :)

l'indentation est désormais de 2 espaces

francoislg · 2017-06-20T19:34:44Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+
+                foreach (string extensionType in extensionTypesToExclude) {
+
+                    if (extensionType == itemExtension)


Tu veux probablement ignorer la casse.

Tu peux aussi remplacer ta boucle par un .Any en LINQ:

if(extensionTypesToExclude.Any(toExclude => StringComparer.OrdinalIgnoreCase.Equals(toExclude, itemExtension))) { args.IsExcluded = true; }

francoislg · 2017-06-20T19:35:02Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+
+            if (args.IndexableToIndex != null && !args.IsExcluded && ShouldExecute(args))
+            {
+                string itemExtension = args.IndexableToIndex.Item.GetFieldValue("Extension");


Mettre Extension en constante?

francoislg · 2017-06-20T19:36:15Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

    <div class="navbar-coveo">
-        <div id="@Model.SearchboxId">
+        <div id="@Model.SearchboxId"  style="display:none">


Space de trop

francoislg · 2017-06-20T19:38:44Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

@@ -78,4 +65,70 @@

        </div>
    </div>
+    <script>
+        function setCookie(cname, cvalue, exdays) {


Peux-tu scoper ça dans un autre fichier? Surtout scoper dans un module en fait....

C'est une feature pas mal standalone la switch pour activer Coveo, quelqu'un qui part de ça et qui veut pas la feature pourrait juste retirer 1 ligne pour toute flusher.

francoislg · 2017-06-20T19:53:24Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitat.css

 .coveo-title > a.CoveoResultLink:visited {
    color: #2e384e;
    font-weight: 600;
 }

-.result-summary,
-.result-summary > p {
+.result-summary{


francoislg · 2017-06-20T19:53:33Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitat.css

-.CoveoResultLink:hover, a.CoveoResultLink:hover, .CoveoResult a.CoveoResultLink:hover{
+.CoveoResultLink:hover, 
+a.CoveoResultLink:hover, 
+.CoveoResult a.CoveoResultLink:hover{


francoislg · 2017-06-20T19:54:21Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitat.css

+
+/* No Results */
+
+.coveo-query-summary-no-results-string{


Encore space, lui d'après aussi :)

francoislg · 2017-06-20T19:54:56Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitatSearchbox.css

+    background-color: rgb(140,140,140);
+}
+
+.activate-coveo {


Place le direct en haut avec l'autre

francoislg · 2017-06-20T19:55:08Z

src/Project/Habitat/code/styles/Habitat/CoveoHabitatSearchbox.css

+}
+
+.activate-coveo:hover {
+    background-color: rgb(220,90,0);


direct en haut avec cursor: pointer

jflheureux · 2017-06-20T18:57:59Z

gulpfile.js

-  return gulp.src(solution).pipe(nugetRestore());
+    var solution = "./" + config.solutionName + ".sln";
+    return gulp.src(solution).pipe(nugetRestore({
+        additionalArgs: ["-Msbuildversion", "4"]


C'est pas done. C'est encore en 4 espaces.

jflheureux · 2017-06-20T18:59:03Z

gulpfile.js

-  return gulp.src(solution).pipe(nugetRestore());
+    var solution = "./" + config.solutionName + ".sln";
+    return gulp.src(solution).pipe(nugetRestore({
+        additionalArgs: ["-Msbuildversion", "4"]


Ne pas committer notre flag de MSBuild version 4. C'est un workaround que nous avons besoin à l'interne mais que le reste du monde n'a pas besoin.

jflheureux · 2017-06-20T19:08:26Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

-<?xml version="1.0" encoding="utf-8"?>
-
-<configuration xmlns:patch="http://www.sitecore.net/xmlconfig/" xmlns:set="http://www.sitecore.net/xmlconfig/set/">
+<configuration 


La ligne XML n'est toujours pas là

jflheureux · 2017-06-20T19:08:41Z

src/Foundation/CoveoIndexing/code/App_Config/Include/Foundation/Foundation.CoveoIndexing.config

-
-<configuration xmlns:patch="http://www.sitecore.net/xmlconfig/" xmlns:set="http://www.sitecore.net/xmlconfig/set/">
+<configuration 
+  xmlns:patch="http://www.sitecore.net/xmlconfig/">


Ce n'est toujours pas fait.

jflheureux · 2017-06-20T19:13:26Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+                string itemExtension = args.IndexableToIndex.Item.GetFieldValue("Extension");
+
+                foreach (string extensionType in extensionTypesToExclude) {
+


Pas de ligne vide après un foreach

jflheureux · 2017-06-20T20:37:00Z

...t/serialization/Habitat.Website.Templates/Habitat/Page Types/News List/__Standard Values.yml

+        <r
+          ds=""
+          id="{E9ECDF34-1EB8-4466-9615-CBAD9E0E7CD9}"
+          par="SearchBoxUniqueId&amp;SearchPageItemId&amp;KeepOmniboxSuggestionsProvidersDefaultOrdering&amp;FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;ResultsPerPage=10&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_6F3769A8-2EC7-4160-8492-E647507ACB9F"


pas de datasource ici?

jflheureux · 2017-06-20T20:37:04Z

...rialization/Habitat.Website.Templates/Habitat/Page Types/Register Page/__Standard Values.yml

+        <r
+          ds=""
+          id="{E9ECDF34-1EB8-4466-9615-CBAD9E0E7CD9}"
+          par="SearchBoxUniqueId&amp;SearchPageItemId&amp;KeepOmniboxSuggestionsProvidersDefaultOrdering&amp;FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;ResultsPerPage=10&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_C29EEEEC-A038-4022-8BB9-EDE71E064626"


pas de datasource ici?

jflheureux · 2017-06-20T20:37:08Z

...ialization/Habitat.Website.Templates/Habitat/Page Types/Search Results/__Standard Values.yml

+        <r
+          ds=""
+          id="{E9ECDF34-1EB8-4466-9615-CBAD9E0E7CD9}"
+          par="SearchBoxUniqueId&amp;SearchPageItemId&amp;KeepOmniboxSuggestionsProvidersDefaultOrdering&amp;FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;ResultsPerPage=10&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_7F51AE1D-66E1-49FF-98A0-8D6580C1BDAD"


pas de datasource ici?

jflheureux · 2017-06-20T20:37:12Z

...tat/serialization/Habitat.Website.Templates/Habitat/Page Types/Section/__Standard Values.yml

+        <r
+          ds=""
+          id="{E9ECDF34-1EB8-4466-9615-CBAD9E0E7CD9}"
+          par="SearchBoxUniqueId&amp;SearchPageItemId&amp;KeepOmniboxSuggestionsProvidersDefaultOrdering&amp;FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;ResultsPerPage=10&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_D04CCB76-3E4C-47CC-AEB7-8D7B499D779E"


pas de datasource ici?

Il manque toujours la datasource ici.

jflheureux · 2017-06-20T20:38:21Z

...roject/Habitat/serialization/Project.Habitat.Roles/habitat/Project Habitat Modules Admin.yml

@@ -5,9 +5,9 @@ MemberOf:
  Role: |
    modules\Feature Multisite Admin
  Role: |
-    modules\Feature Social Admin


Surement pas la même version de Unicorn utilisée pour le sync initial et cette modif. Je suis d'accord avec François. Peux-tu resturer l'ordre (à la main au pire)

vbernard-coveo · 2017-05-29T19:17:56Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeImageFiles.cs

+        {
+            if (args.IndexableToIndex != null && !args.IsExcluded && ShouldExecute(args))
+            {
+                var extension = args.IndexableToIndex.Item.GetFieldValue("Extension");


vbernard-coveo · 2017-05-29T19:20:20Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeImageFiles.cs

+            {
+                var extension = args.IndexableToIndex.Item.GetFieldValue("Extension");
+
+                if ((extension == "gif") || (extension == "png") || (extension == "jpg"))


vbernard-coveo · 2017-05-29T19:20:25Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeVideoFiles.cs

+        {
+            if (args.IndexableToIndex != null && !args.IsExcluded && ShouldExecute(args))
+            {
+                var extension = args.IndexableToIndex.Item.GetFieldValue("Extension");


vbernard-coveo · 2017-05-29T20:58:22Z

src/Project/Common/code/styles/Common/CoveoSearch.css

@@ -0,0 +1,12 @@
+.CoveoSearchbox {


vbernard-coveo · 2017-05-29T20:58:44Z

src/Project/Common/code/styles/Common/CoveoSearch.css

+    float: right
+}
+
+body * {


vbernard-coveo · 2017-06-22T19:41:24Z

src/Project/Habitat/code/Sitecore.Habitat.Website.csproj

-  <ItemGroup>
-    <Folder Include="Views\Website\Sublayouts\" />
-  </ItemGroup>
+  <ItemGroup />


je ne le vois pas de mon bord (Sitecore.Habitat.Website.csproj ligne 187 dans Notepad++)

vbernard-coveo · 2017-06-22T19:44:33Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+        </div>
+    </div>
+    <script>
+        function setCookie(cname, cvalue, exdays) {


pas à ma connaissance. jquery.cookie est une librairie externe qui permet ce genre de fonction, pas certain qu'on veuille l'inclure

vbernard-coveo · 2017-06-22T19:46:59Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+        function getCookie(cname) {
+            var name = cname + "=";
+            var decodedCookie = decodeURIComponent(document.cookie);
+            var ca = decodedCookie.split(';');


vbernard-coveo · 2017-06-22T19:47:20Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+            var name = cname + "=";
+            var decodedCookie = decodeURIComponent(document.cookie);
+            var ca = decodedCookie.split(';');
+            for(var i = 0; i <ca.length; i++) {


vbernard-coveo · 2017-06-22T19:49:47Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+            return "";
+        };
+
+        var coveoSearchBox = document.getElementById('@Model.SearchboxId');


francoislg · 2017-06-27T14:23:44Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

-        function getCookie(cname) {
-            var name = cname + "=";
+
+    class CoveoSearchboxSwitcher{


francoislg · 2017-06-27T14:26:27Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

-        function getCookie(cname) {
-            var name = cname + "=";
+
+    class CoveoSearchboxSwitcher{


class est pas supporté en IE11...

Tu devrais sois le compiler ou juste faire un scope minimal juste pour encapsuler.

Si tu pouvais le mettre dans un fichier appart aussi...

francoislg · 2017-06-27T14:27:12Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+        function getCookie(cname) {
+            var name = cname + "=";
+            var decodedCookie = decodeURIComponent(document.cookie);
+            var ca = decodedCookie.split(';');


Pas OK, il s'appelle encore ca. Change pour allCookies ou quelque chose du genre.

francoislg · 2017-06-27T14:27:22Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

-            }else{
-                switchCoveoOn();
-            };
+        switchCoveoOff(){


francoislg · 2017-06-27T14:27:27Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

-        function toggleCoveoSearchbox(){
-
-            coveoSearchBoxCookie = getCookie("coveoSearchBox");
+        switchCoveoOn(){


francoislg · 2017-06-27T14:27:38Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+            this.setCookie(this.constants.cookieName, this.constants.on, 30);
+        };
+
+        checkCoveoSwitchCookie(){


Oui, Comme dit François, on met toujours une espace avant l'accolade ouvrante:
something() { ... }

francoislg · 2017-06-27T14:32:04Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+    };
+
+    coveoSearchboxSwitcher = new CoveoSearchboxSwitcher();
+    coveoSearchboxSwitcher.checkCoveoSwitchCookie();


J'aime encore mieux "initialize" ou "setInitialState()"

jflheureux · 2017-07-13T15:53:44Z

src/Foundation/CoveoIndexing/code/Constants.cs

@@ -0,0 +1,11 @@
+namespace Sitecore.Foundation.CoveoIndexing
+{
+  internal struct Constants


Formatte les fichier C# avec 4 espaces pour l'indentation au lieu de 2. C'est ce qui est par défaut dans le fichier .editorconfig à la racine du repo.

jflheureux · 2017-07-13T15:54:08Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+
+namespace Sitecore.Foundation.CoveoIndexing
+{
+  public class ExcludeFilesWithExtensionTypes : AbstractCoveoInboundFilterProcessor


indentation 4 espaces

jflheureux · 2017-07-13T15:55:56Z

src/Foundation/CoveoIndexing/code/Constants.cs

+  {
+    internal struct ExcludeFilesWithExtension
+    {
+      public const char FileExtensionSeparator = ';';


Cette constante peut aller dans le fichier ExcludeFilesWithExtensionTypes.cs car elle est vraiment propre à ce processeur. Elle devra alors être en majuscules et private: private const string FILE_EXTENSION_SEPARATOR

Le fichier Constants.cs doit être utilisé pour les constantes utilisées à plus d'un endroit et les ID d'items Sitecore, noms de fields... par exemple.

jflheureux · 2017-07-13T15:56:24Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+  public class ExcludeFilesWithExtensionTypes : AbstractCoveoInboundFilterProcessor
+  {
+    /// <summary>
+    /// ID of the field where activation checkbox is specified.


activation checkbox?

jflheureux · 2017-07-13T15:57:36Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+
+    public override void Process(CoveoInboundFilterPipelineArgs args)
+    {
+      string[] extensionTypesToExclude = ExtensionTypesToExclude.Split(Constants.ExcludeFilesWithExtension.FileExtensionSeparator);


Tu peux déplacer cette ligne à l'intérieur du IF. Ça va éviter de faire cette opération pour rien si l'item est déjà exclus.

jflheureux · 2017-07-18T18:42:38Z

src/Project/Habitat/serialization/Habitat.Website.Content/Habitat/Home/CoveoSearch.yml

+    - ID: "ca0479ce-0bfe-4522-83de-ba688b380a78"
+      Hint: BrowserTitle
+      Value: Search Results
+- Language: "ja-JP"


Not fixed. À adresser.

jflheureux · 2017-07-18T18:43:05Z

.../Habitat/serialization/Habitat.Website.Content/Habitat/Home/Modules/Feature/Coveo Search.yml

+  - Version: 1
+    Fields:
+    - ID: "04bf00db-f5fb-41f7-8ab7-22408372a981"
+      Hint: __Final Renderings


Not fixed. À adresser.

jflheureux · 2017-07-18T18:45:54Z

...n/Habitat.Website.Content/Habitat/Settings/Datasources/Coveo/Coveo Search Box Parameters.yml

+    - ID: "2f5ef5f2-5b9a-4ce3-9596-3d7654203648"
+      Hint: EnableSitecoreAnalytics
+      Type: Checkbox
+      Value: 0


J'aimerais qu'on active les Sitecore Analytics dans nos components de demo.

jflheureux · 2017-07-18T18:47:27Z

...n/Habitat.Website.Content/Habitat/Settings/Datasources/Coveo/Coveo Search Box Parameters.yml

+ID: "d93961e6-59a5-4532-98b2-1d98ab0d34e4"
+Parent: "24e745e1-181e-457b-aad0-1caf5ddce16c"
+Template: "294075e4-cb2c-4e5f-a646-416fc078581f"
+Path: /sitecore/content/Habitat/Settings/Datasources/Coveo/Coveo Search Box Parameters


J'aimerais qu'on désactive le "focus on page load" pour la searchbox.

Thread done.

jflheureux · 2017-07-18T18:48:57Z

src/Project/Habitat/serialization/Habitat.Website.Renderings/Habitat/Coveo Search Box View.yml

+  Value: /sitecore/content/Habitat/Settings/Datasources/Coveo/Coveo Search Box Parameters
+- ID: "4867d192-326a-4aa4-81ef-ea430e224aff"
+  Hint: Css assets
+  Value: /styles/Habitat/CoveoHabitatSearchbox.css, /styles/Common/CoveoSearch.css


Serait-il mieux de loader common avant Habitat?

Also fixed some code here and there from my code review comments

! Fixed inbound filter namespace change in config. - Patch deleted default Coveo indexes. - Removed bugged serverUrl setting.

* Removed bold and uppercase from searchbox. ! Fixed JS endpoint introduced yesterday. ! Fixed JS call when switching Lucene/Coveo.

jflheureux · 2017-07-19T20:59:13Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+        });
+    </script>
+
+    <div class="activate-coveo" title="Activate Coveo Searchbox" onclick="coveoSearchboxSwitcher.toggleCoveoSearchbox()" style="display:none"></div>


Ce toggle doit être dans sa propre view. Le code JS associé devrait être dans un fichier JS séparé aussi pour améliorer le caching côté browser.

jflheureux · 2017-07-19T21:27:23Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+    </div>
+
+    <script>
+        class CoveoSearchboxSwitcher{


Convertir cette class ES2015 en ES5 pour qu'elle soit compatible avec tous les browsers supportés.

jflheureux · 2017-07-19T21:28:02Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+            getCookie(cookieName) {
+                var name = cookieName + "=";
+                var decodedCookie = decodeURIComponent(document.cookie);
+                var ca = decodedCookie.split(';');


Donner un nom de variable clair qui explique l'utilité de celle-ci.

jflheureux · 2017-07-19T21:28:15Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+                var decodedCookie = decodeURIComponent(document.cookie);
+                var ca = decodedCookie.split(';');
+                for (var i = 0; i < ca.length; i++) {
+                    var c = ca[i];


Donner un nom de variable clair qui explique l'utilité de celle-ci.

jflheureux · 2017-07-19T21:29:31Z

src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

+        };
+
+        coveoSearchboxSwitcher = new CoveoSearchboxSwitcher();
+        coveoSearchboxSwitcher.checkCoveoSwitchCookie();


Changer le nom de la méthode pour "initialize" ou "setInitialState"...

jflheureux · 2017-07-19T21:32:45Z

src/Project/Habitat/code/Views/Habitat/SearchView.cshtml

+        Coveo.$(function() {
+            CoveoForSitecore.componentsOptions = @(Html.Raw(Model.GetJavaScriptInitializationOptions()));
+            if (CoveoForSitecore.externalComponents) {
+                CoveoForSitecore.componentsOptions.externalComponents = CoveoForSitecore.externalComponents;


Pourquoi utiliser un array temporaire (CoveoForSitecore.externalComponents) ici? Pourquoi ne pas coder la searchbox pour qu'elle s'ajoute directement à l'array CoveoForSitecore.componentsOptions.externalComponents?

Thread done

jflheureux · 2017-07-19T21:33:58Z

src/Project/Habitat/code/Views/Habitat/SearchView.cshtml

+                                        {{ if (raw.syssource === "Sitecore Habitat Videos") { }}
+                                            <span class="CoveoYouTubeThumbnail" data-width='100%' data-height='auto'></span>
+                                        {{ } else { }}
+                                            <div class="page-icon-container CoveoQuickview"


Le div CoveoQuickview devrait toujours être dans un if (hasHtmlVersion). L'afficher sans html version va faire une erreur en ouvrant le dialogue du quickview.

…Coveo into CoveoFoundation # Conflicts: # src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

…s, few adjustements in SearchView and SearchBoxView

… convert SearchboxSwitcher to standard JS

jflheureux · 2017-09-29T11:37:51Z

src/Feature/CoveoSearch/code/Views/CoveoSearch/SearchboxSwitcherView.cshtml

@@ -0,0 +1 @@
+<div class="searchbox-switcher disabled" title="" onclick="coveoSearchboxSwitcher.toggleSearchboxOnClick()"></div>


Ici le code assume que la variable globale coveoSearchboxSwitcher existe. Il serait peut-être mieux d'attacher le click handler lors du constructeur de la classe ou bien lors du DOMContentLoaded. Qu'en penses-tu?

jflheureux · 2017-09-29T11:47:40Z

src/Foundation/CoveoIndexing/code/InboundFilters/ExcludeFilesWithExtensionTypes.cs

+        public override void Process(CoveoInboundFilterPipelineArgs args)
+        {
+            if (args.IndexableToIndex != null && !args.IsExcluded && this.ShouldExecute(args)) {
+                string[] extensionTypesToExclude = this.ExtensionTypesToExclude.Split(FILE_EXTENSION_SEPARATOR);


"this." n'est pas nécessaire et ajoute plus de bruit qu'autre chose en C#

jflheureux · 2017-09-29T11:56:43Z

src/Foundation/CoveoIndexing/code/packages.config

 <packages>
  <package id="Microsoft.AspNet.Mvc" version="5.2.3" targetFramework="net46" />
  <package id="Microsoft.AspNet.Razor" version="3.2.3" targetFramework="net46" />
  <package id="Microsoft.AspNet.WebPages" version="3.2.3" targetFramework="net46" />
  <package id="Microsoft.CodeDom.Providers.DotNetCompilerPlatform" version="1.0.3" targetFramework="net46" />
  <package id="Microsoft.Net.Compilers" version="1.3.2" targetFramework="net46" developmentDependency="true" />
  <package id="Microsoft.Web.Infrastructure" version="1.0.0.0" targetFramework="net46" />
+  <package id="Sitecore.Kernel.NoReferences" version="8.2.161115" targetFramework="net46" developmentDependency="true" />


Je ne suis pas certain à propos de developmentDependency puisque cet assembly est nécessaire au runtime pour le projet, pas juste pour compiler.

jflheureux · 2017-09-29T14:40:37Z

src/Project/Habitat/code/Sitecore.Habitat.Website.csproj

@@ -250,5 +252,4 @@
  </Target>
  <Target Name="AfterBuild">
  </Target> -->
-</Project>
-
+</Project>


Ce problème de saut de ligne ne semble pas fixé.

jflheureux · 2017-09-29T17:21:54Z

...ation/Habitat.Website.Content/8481ebe7-0c85-4f68-904f-9a4e699e9d2c/Local Content Example.yml

@@ -1,4 +1,4 @@
---
+---


Peux-tu restaurer le fichier original svp? Celui que tu as présentement a un BOM en début de fichier et il manque une fin de ligne à la fin.

jflheureux · 2017-09-29T17:29:16Z

...erialization/Habitat.Website.Templates/Habitat/Page Types/Coveo Search/__Standard Values.yml

+        <r
+          ds="{4E48D10A-1717-4D1E-9D78-C665CC4F290F}"
+          id="{2BCAC115-1C0F-49C7-8A73-1E82F5EF8BB4}"
+          par="FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;PagerLocation=%7BA1FBD885-7B5E-4AD3-87D1-06AB48937629%7D&amp;ResultsPerPage=10&amp;PagerShowPreviousNext=1&amp;PagerNumberOfPages=10&amp;PagerMaxNumberOfPages=100&amp;QuerySummaryEnableSearchTips=1&amp;QuerySummaryOnlyDisplaySearchTips&amp;DidYouMeanEnableAutoCorrection=1&amp;EnableInfiniteScroll&amp;InfiniteScrollPageSize=10&amp;DisplayResultsPerPage=1&amp;DisplayFacets=1&amp;DisplayLogo=1&amp;DisplaySearchBox=1&amp;DisplaySorting=1&amp;HideUntilFirstQuery=1&amp;DisplayQueryDuration=1&amp;DisplayQuerySummary=1&amp;DisplayBreadcrumb=1&amp;DisplayDidYouMean=1&amp;DisplayErrorReport=1&amp;DisplayRecommendations=1&amp;DisplayResultList=1&amp;DisplayTabs=1&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;AutoTriggerQuery=1&amp;ExcerptLength=200&amp;EnableHistory=1&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_7CDDAF40-26B8-4B96-8E3B-54BA20527EBB"


Thread done

jflheureux · 2017-09-29T17:29:45Z

...abitat/serialization/Habitat.Website.Templates/Habitat/Page Types/Home/__Standard Values.yml

+        <r
+          ds="{D93961E6-59A5-4532-98B2-1D98AB0D34E4}"
+          id="{E9ECDF34-1EB8-4466-9615-CBAD9E0E7CD9}"
+          par="SearchBoxUniqueId&amp;SearchPageItemId&amp;KeepOmniboxSuggestionsProvidersDefaultOrdering&amp;FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;ResultsPerPage=10&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_295304F0-C550-4340-8B08-A3354FD878E3"


Thread done

jflheureux · 2017-09-29T17:30:38Z

...tat/serialization/Habitat.Website.Templates/Habitat/Page Types/Section/__Standard Values.yml

+          ph="navbar-activity"
+          uid="{F0B59CCD-EC41-4E3E-9F8C-BAC228657FED}" />
+        <r
+          ds=""


Il manque ds="{D93961E6-59A5-4532-98B2-1D98AB0D34E4}" pour être pareil come les autres.

jflheureux · 2017-09-29T17:30:52Z

...tat/serialization/Habitat.Website.Templates/Habitat/Page Types/Section/__Standard Values.yml

+        <r
+          ds=""
+          id="{E9ECDF34-1EB8-4466-9615-CBAD9E0E7CD9}"
+          par="SearchBoxUniqueId&amp;SearchPageItemId&amp;KeepOmniboxSuggestionsProvidersDefaultOrdering&amp;FilterExpressionRules&amp;BoostExpressionRules&amp;EnableAutomaticBoosting&amp;FilterCulture=1&amp;SearchBoxBehavior&amp;EnablePartialMatch&amp;PartialMatchKeywords=5&amp;PartialMatchThreshold=50%25&amp;EnableWildcards&amp;EnableQuestionMarks&amp;EnableLowercaseOperators&amp;ResultsPerPage=10&amp;DefaultSortType&amp;DefaultSortDirection&amp;DefaultSortField&amp;SearchBoxPlaceholderText&amp;AutoFocus=1&amp;ExternalContentSources&amp;ExternalContentCollections&amp;EnableCoveoUsageAnalytics=1&amp;CoveoUsageAnalyticsCustomMetadata&amp;EnableSitecoreAnalytics&amp;SitecoreAnalyticsRestUri=%2Fcoveo%2Frest%2Fv6%2Fanalytics&amp;ThrowExceptionOnValidationError&amp;EnableClientSideLogging&amp;IncludeBucketFoldersInResults&amp;IncludeMediaFoldersInResults&amp;QueryPipelineName&amp;RestUri=%2Fcoveo%2Frest&amp;OmniboxEnableFieldAddon&amp;OmniboxEnableSimpleFieldAddon&amp;OmniboxEnableQueryExtensionAddon&amp;ItemId=_D04CCB76-3E4C-47CC-AEB7-8D7B499D779E"


Il manque toujours la datasource ici.

jflheureux · 2017-09-29T17:31:23Z

...roject/Habitat/serialization/Project.Habitat.Roles/habitat/Project Habitat Modules Admin.yml

@@ -37,4 +37,4 @@ MemberOf:
  Role: |
    modules\Feature Accounts Admin
  Role: |
-    modules\Feature PageContent Admin
+    modules\Feature PageContent Admin


Peux-tu restaurer le fichier original svp? Celui que tu as présentement manque une fin de ligne à la fin.

vbernard-coveo added 14 commits April 5, 2017 15:14

first build

d9d1106

Added App_Config, Processor and InboudFilter

465386b

Moved some files from root to /Foundation/CoveoIndexing

9a37675

I also added some references for the project to build.

Update config for serialization

26eee60

Adding serialized items

34eb73f

Items serialized in CoveoSearch Feature

Revert "first build"

2c8899c

This reverts commit d9d1106.

Revert "Adding serialized items"

891924a

This reverts commit 34eb73f.

Change gitignore file

1164f81

Namespace change in CoveoIndexing foundation

1aff014

Configured CoveoSearch and CoveoIndexing serialization

c353f70

Merge remote-tracking branch 'refs/remotes/origin/CoveoFoundation' in…

4951626

…to CoveoSearch-Components

Removed verticals indexes

e710cfd

Add Habitat index

ab87e86

Serialize CoveoIndexing facets

193a062

jflheureux suggested changes Apr 10, 2017

View reviewed changes

vbernard-coveo added 9 commits April 10, 2017 20:11

Merge pull request #2 from coveord/CoveoSearch-Components

5637ef5

Coveosearch components

Remove 2 verticals inbound filters, removed copyright, removed some f…

96fbdae

…ields

Revert .vs folder in .gitignore

d9e7f63

Added Coveo Assemblies to gulp sequence and to gitignore

ed40c50

Remove map point category field

5c7c52f

Split Sitecore and Coveo DLL, exclude 2 inbound filters

e415358

gulpfile typo

a98d5ae

remove field

8d76510

deleted config file in .vs folder

da1145c

jflheureux suggested changes Apr 11, 2017

View reviewed changes

vbernard-coveo added 5 commits April 11, 2017 11:36

Change facet serialization folder

ace7488

Adjusting HasLayout inbound filter

550ca34

Moved configs in Project level, change Sitecore assemblies for the nu…

ca09678

…gets packages

Indentation

f56bfde

Remove sitecore assemblies from gulp file

ea211fc

vbernard-coveo added 5 commits April 20, 2017 14:21

Removed coveo navbar, revert all standard values to original navbar. …

e76cf7f

…Include original searchbox in home Also recreate orginal search page, and create CoveoSearch page

Rolled back the _Standard Value modification to be original and inclu…

f5c6d33

…de Coveo at the end

Added quickview CSS and rules on the search page

4a43a9a

Quickview overlay

375dbb4

Added switch for Habitat and Coveo searchbox, removed from final layo…

e414779

…ut sorting and put them back in __Standard values

francoislg suggested changes May 3, 2017

View reviewed changes

vbernard-coveo added 2 commits May 29, 2017 17:53

Reviewed flguillemette comments

c58e3bd

Paul's modification

9c92360

Corrected search view and Search boxes

francoislg suggested changes Jun 20, 2017

View reviewed changes

jflheureux suggested changes Jun 20, 2017

View reviewed changes

Corretion to jeff comments

cab4530

vbernard-coveo commented Jun 27, 2017

View reviewed changes

francoislg suggested changes Jun 27, 2017

View reviewed changes

jflheureux suggested changes Jul 18, 2017

View reviewed changes

Jean-François LHeureux added 4 commits July 18, 2017 17:59

Fixed code styling and formatting

a93ccfc

Also fixed some code here and there from my code review comments

Configuration changes

47b9adc

! Fixed inbound filter namespace change in config. - Patch deleted default Coveo indexes. - Removed bugged serverUrl setting.

Various fixes

1b2ca52

* Removed bold and uppercase from searchbox. ! Fixed JS endpoint introduced yesterday. ! Fixed JS call when switching Lucene/Coveo.

Small fixes related to my code review

5623eec

jflheureux suggested changes Jul 19, 2017

View reviewed changes

vbernard-coveo added 9 commits August 1, 2017 21:31

Correct javascript in SearchBoxView for the switcher

32c1b87

Merge branch 'CoveoFoundation' of https://github.com/coveord/Habitat.…

66412e7

…Coveo into CoveoFoundation # Conflicts: # src/Project/Habitat/code/Views/Habitat/SearchBoxView.cshtml

no message

66ca53f

end lines

1ce5f0f

Corrected few jeff comments from Juley 2017

c8c9eb7

changes in SearchboxSwitcher, modification to every _ _Standard Value…

9441575

…s, few adjustements in SearchView and SearchBoxView

YML items corrections

b319fb8

Added datasource to each SearchboxView item in the __Standard Values.…

edac1b3

… convert SearchboxSwitcher to standard JS

Added datasources for all Coveo components

2d52f70

jflheureux suggested changes Sep 29, 2017

View reviewed changes

		@@ -1,12 +1,12 @@
		<?xml version="1.0" encoding="utf-8"?>
		<?xml version="1.0" encoding="utf-8"?>

		@@ -0,0 +1,155 @@
		// Copyright (c) 2005-2017, Coveo Solutions Inc.

		string itemExtension = args.IndexableToIndex.Item.GetFieldValue("Extension");

		foreach (string extensionType in extensionTypesToExclude) {


		foreach (string extensionType in extensionTypesToExclude) {

		if (extensionType == itemExtension)

		@@ -0,0 +1 @@
		<div class="searchbox-switcher disabled" title="" onclick="coveoSearchboxSwitcher.toggleSearchboxOnClick()"></div>


		/* No Results */

		.coveo-query-summary-no-results-string{

Coveofoundation #1

Are you sure you want to change the base?

Coveofoundation #1

Conversation

vbernard-coveo commented Apr 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francoislg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment