Merge pull request #108 from cowlicks/update-docs

Update some docs
cowlicks · Sep 2, 2018 · 1d66ebf · 1d66ebf
2 parents 5c14304 + c68352c
commit 1d66ebf
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/docs/moz-validation-results b/docs/moz-validation-results
@@ -0,0 +1,17 @@
+Comments on validation results:
+
+Unsafe assignment to innerHTML Warning
+js/test/testing_utils.js
+
+The refers to code in a unittest, which is not exposed to functioning addon at all. We use the code to clear fake dom between unit tests.
+
+Known JS library detected warnings: 
+js/external/react/react.production.min.js
+js/external/react-dom/react-dom.production.min.js
+
+I use react for the popup. I don't use jsx so I can avoid transpiling.
+
+Violation of Mozilla conditions of use Warning: Words found that violate the Mozilla conditions of use
+js/domains/psl.js
+
+This is referring to some domain name in Mozilla's own Public Suffix list. I use this list to determine what is a 3rd party.
diff --git a/docs/notes.md b/docs/notes.md
@@ -26,12 +26,9 @@
 * add promotional titles to chrome Small tile - 440x280, Large tile - 920x680, Marquee - 1400x560
 * handlers should just be for dispatching stuff, not starting listeners
 
-* consider injecting contentscripts programatically
-* add html tooling
 * update psl script to reflect new location
 * error getting fingerprinting message from tabId=-1? from extension?
 * error when inspect popup creates it, make currentTab work with this
-* fix webrequest requestHandler loop
 * change badge text color to grey
 * make icon not blurry in chrome store?
 * add screenshots for chrome store, resize current ones to 1280 pixels wide and 800 pixels high