Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added short_name #100

Merged
merged 2 commits into from Sep 2, 2018
Merged

added short_name #100

merged 2 commits into from Sep 2, 2018

Conversation

ghost
Copy link

@ghost ghost commented Aug 25, 2018

From your todo-list:

add short name to manifest for chrome store

adds short_name and therefore I would make the normal name a bit "longer" or more informative.

@cowlicks
Copy link
Owner

Thanks @BO41 ! I looked at the google docs and they recommend the short_name be less than 12 characters. I'm not sure of a nice way of squashing "Privacy Possum" into that.

@ghost
Copy link
Author

ghost commented Aug 26, 2018

@cowlicks well it is just a recommendation.
And if this is the name of the project, what should you do?

Maybe just call it "Possum" or "P Possum" or something like this.
Or just leave it with 14 characters

@ghost
Copy link
Author

ghost commented Aug 26, 2018

another option, but not serious, would be "privacypo§um".
then it would fit into 12 characters 😁

@cowlicks
Copy link
Owner

@BO41 How about "PrivacyPoßum"? I'd prefer to keep"name" as "Privacy Possum". I'm happy to merge with those changes.

Thanks!

@ghost
Copy link
Author

ghost commented Aug 31, 2018

so short_name "PrivacyPoßum" and name "Privacy Possum"?

or just leave it as it is. Maybe you will find a better solution some day

@cowlicks cowlicks merged commit f0b66d8 into cowlicks:master Sep 2, 2018
@cowlicks
Copy link
Owner

cowlicks commented Sep 2, 2018

@BO41 I decided to just omit the short_name because having diverging branding seems like it might cause problems down the road. I merged your commits + my changes. Thanks for the help!

@ghost ghost deleted the patch-1 branch September 2, 2018 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant