Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some docs #108

Merged
merged 2 commits into from
Sep 2, 2018
Merged

Update some docs #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aca1fa7
Rm some old todos
cowlicks Aug 31, 2018
c68352c
Add response to Mozilla's auto-code validation
cowlicks Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/moz-validation-results
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
Comments on validation results:

Unsafe assignment to innerHTML Warning
js/test/testing_utils.js

The refers to code in a unittest, which is not exposed to functioning addon at all. We use the code to clear fake dom between unit tests.

Known JS library detected warnings:
js/external/react/react.production.min.js
js/external/react-dom/react-dom.production.min.js

I use react for the popup. I don't use jsx so I can avoid transpiling.

Violation of Mozilla conditions of use Warning: Words found that violate the Mozilla conditions of use
js/domains/psl.js

This is referring to some domain name in Mozilla's own Public Suffix list. I use this list to determine what is a 3rd party.
3 changes: 0 additions & 3 deletions docs/notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,9 @@
* add promotional titles to chrome Small tile - 440x280, Large tile - 920x680, Marquee - 1400x560
* handlers should just be for dispatching stuff, not starting listeners

* consider injecting contentscripts programatically
* add html tooling
* update psl script to reflect new location
* error getting fingerprinting message from tabId=-1? from extension?
* error when inspect popup creates it, make currentTab work with this
* fix webrequest requestHandler loop
* change badge text color to grey
* add short name to manifest for chrome store
* make icon not blurry in chrome store?
Expand Down