Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve isRequestThirdParty using details.initiator #110

Merged
merged 5 commits into from
Sep 2, 2018
Merged

Improve isRequestThirdParty using details.initiator #110

merged 5 commits into from
Sep 2, 2018

Conversation

cowlicks
Copy link
Owner

@cowlicks cowlicks commented Sep 2, 2018

We now make it use details.initiator as much as possible. This closes #89. Adds tests for Tabs.isRequestThirdParty.

For posterity, the way I was able to start Firefox with the development addon installed was:

  • Use firefox development edition
  • goto about:config and set xpinstall.signatures.required = false
  • Build extension with web-ext
  • drag built extension into about:addons to install it
  • set homepage to the broken site (netvibes.com)
  • close firefox and re-open it

@cowlicks cowlicks mentioned this pull request Sep 2, 2018
Closed
@cowlicks cowlicks merged commit 535afd6 into master Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PP Breaks Nwetvibes/RSS Reader
1 participant
@cowlicks