WIP: Switch from commonjs to ESM #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm test -- test/suffixtree_test.js works now
|
To make this work, I need to create at background.html page, which loads the scripts that are currently in manifest.json:background:scripts. There is no safe way to use ESM modules in content scripts. But these are fairly contained so don't need the ESM stuff. |
cowlicks
commented
Aug 17, 2020
| /** | ||
| * we load these lazily. | ||
| */ | ||
|
|
||
| import {FakeMessages, FakeDisk, Connects} from './fakes.js'; | ||
|
|
||
| function wrapObject(base) { |
There was a problem hiding this comment.
I added features to this thing that I'm barely using. It's handy and I should document it.
|
Popup and background are good. I need to check the content scripts next |
|
Content scripts working. Need to test in FF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unit tests are working locally
browser stuff is untested