-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: use user interactions to whitelist hosts. #76
base: master
Are you sure you want to change the base?
Conversation
bccf9eb
to
efce34f
Compare
I am involved with some files than need some change also. |
any updates on this? |
0f0a4d2
to
7fa156b
Compare
@jeroen7s hi! I just rebased this on to master. I think I had intended to merge this after I added selenium tests, and could add tests for this PR. Adding selenium tests was done in #103 and #125. If you'd like to help, I need to go through that todo checklist at the top of this PR, and add tests. Feel free to do that stuff, I happy to answer any questions or emails you have along the way. |
This implements something like what Cliqz does, as described by this this issue.
We create an ephemeral whitelist of domains from user interactions, then check this whitelist when we call
isThirdParty
Todo:
Tabs
instead of eachTab
.Related to #72 and #4