Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use user interactions to whitelist hosts. #76

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

cowlicks
Copy link
Owner

@cowlicks cowlicks commented Jul 3, 2018

This implements something like what Cliqz does, as described by this this issue.

We create an ephemeral whitelist of domains from user interactions, then check this whitelist when we call isThirdParty

Todo:

  • we should probably attach the whitelist to Tabs instead of each Tab.
  • add tests
  • actually find a domain where this fixes an issue, and test it
  • make the whitelist a FIFO cache
  • cache duplicate user interactions in the contentscript so we don't send too many messages
  • add selenium tests

Related to #72 and #4

@jotake
Copy link

jotake commented Oct 1, 2018

I am involved with some files than need some change also.
I I will get some important information from your work.
Have a nice day
Good work

@jeroenev
Copy link

any updates on this?

@cowlicks cowlicks force-pushed the third-party-interactions branch from 0f0a4d2 to 7fa156b Compare January 31, 2019 18:37
@cowlicks
Copy link
Owner Author

cowlicks commented Jan 31, 2019

@jeroen7s hi! I just rebased this on to master. I think I had intended to merge this after I added selenium tests, and could add tests for this PR. Adding selenium tests was done in #103 and #125. If you'd like to help, I need to go through that todo checklist at the top of this PR, and add tests. Feel free to do that stuff, I happy to answer any questions or emails you have along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants