Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] First series of updates for 10_2_X #289

Open
wants to merge 15 commits into
base: CMSSW_10_2_X
Choose a base branch
from

Conversation

pieterdavid
Copy link
Member

@pieterdavid pieterdavid commented Jan 17, 2019

Summary:

  • this makes the framework run with CMSSW 10_2_9, which is recommended for the combined 2016-2017-2018 dataset (rereco up to September 2018, then prompt; re-MiniAOD for 2016)
  • updated electron IDs (Fall17 V2)
  • updated to the latest POG recipes electron scale/smearing and JEC/JER (removed quite some of the 94X cms.Task hacks)
  • (technical) update for setup script (and needed to add the requests python package for updateremotes), silence GCC7 warning about non-virtual destructors for virtual base classes
  • changed the default SCRAM_ARCH to CentOS7, since much of the computing resources is migrating or will do so soon (e.g. lxbatch, grid sites, the cp3 partition on slurm)

Still to do:

  • verify that the electron corrections are actually being applied
  • add 2017 and 2018 data and MC to the tests (era, GT, input files and specifiic configs/recipes, if needed)
  • re-enable fat jets (user float names etc. changed between PUPPI and AK8PF, so I took out the producer for now to save time)
  • update reference trees when we are happy about all the above
  • configure Jenkins to test with CentOS7 as well, at some point
  • backport Split event weight sums out of ExTreeMaker #282

@vischia
Copy link
Contributor

vischia commented Feb 12, 2019

The "details" say "not found", so I guess the test has been run so many days ago that the outcome has been cleaned up by the system. Is there a way of forcing again the test?

@pieterdavid
Copy link
Member Author

Indeed. I think it's possible to retrigger the build in jenkins, but this one is not ready for tests yet anyway (and the test configs will need to change if we want some coverage for the "full run2" sample).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants