[flat.set] [flat.multiset] [flat.map] [flat.multimap] Editorial part of LWG3802 #5923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkoeppe
added
the
needs rebase
Quuxplusone
force-pushed
the
lwg3802-editorial-part
branch
from
ea1e1d4 to
4392055
Compare
|
This has been rebased now. |
…of LWG3802 In LWG3802 I wrote: > (B) Almost certainly the Allocator parameter should be named Alloc instead, > and there should be a separate "Constructors with allocators" section with > wording similar to 24.6.7.3 [priqueue.cons.alloc] explaining that these > ctors don't participate in overload resolution unless > `uses_allocator_v<KeyContainer, Alloc> && uses_allocator_v<MappedContainer, Alloc>`. This is that change. It is intended to be purely editorial (although possibly major/controversial). Specifically this commit is *not* intended to change any signatures, add or remove any signatures, nor trigger/untrigger any blanket wording based on the name of the `Allocator`/`Alloc` parameter.
Quuxplusone
force-pushed
the
lwg3802-editorial-part
branch
from
4392055 to
3ccfbd8
Compare
|
Rebased; ping! I'd like to hear about this one, because it is large and yet the P/R for LWG3802 is based on top of it. |
jensmaurer
removed
the
needs rebase
|
Superseded by #6274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LWG3802 I wrote:
This is that change. It is intended to be purely editorial (although possibly major/controversial). Specifically this commit is not intended to change any signatures, add or remove any signatures, nor trigger/untrigger any blanket wording based on the name of the
Allocator/Allocparameter. If you see anything non-editorial, please call it out, as it's probably a typo on my part.This harmonizes the flat container adaptors' organization with
{stack,queue,priqueue}.cons.alloc.If adopted, I expect this will also make the resolutions for LWG 3802, LWG 3803, and LWG 3804 easier to understand and apply.
I've got proposed wording for the functional part of LWG3802, based on top of this patch; see that (non-editorial) wording here: Quuxplusone@f43c4c3