Skip to content

Commit

Permalink
update todos
Browse files Browse the repository at this point in the history
  • Loading branch information
alex-Arc committed Jan 27, 2025
1 parent 1a68aef commit e6ba880
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
3 changes: 1 addition & 2 deletions apps/server/src/adapters/OscAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ class OscServer implements IAdapter {
// args: extra data, only used on some API entries

/**
* TODO: remove this type casting when mergend in deleration file
* https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71659
* TODO: fix ArrayBuffer casting
*/
const msg = fromBuffer(buf);
if (msg.oscType === 'bundle') {
Expand Down
6 changes: 1 addition & 5 deletions apps/server/src/api-data/automation/clients/osc.client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ function preparePayload(output: OSCOutput, state: RuntimeState): OscPacketInput
function emit(targetIP: string, targetPort: number, packet: OscPacketInput) {
logger.info(LogOrigin.Tx, `Sending OSC: ${targetIP}:${targetPort}`);

/**
* TODO: remove this type casting when change is merged
* https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71659
*/
const buffer = oscPacketToBuffer(packet) as unknown as Uint8Array;
const buffer = oscPacketToBuffer(packet);
udpClient.send(buffer, 0, buffer.byteLength, targetPort, targetIP, (error) => {
if (error) {
logger.warning(LogOrigin.Tx, `Failed sending OSC: ${error}`);
Expand Down

0 comments on commit e6ba880

Please sign in to comment.