Skip to content

Commit

Permalink
Merge branch '__rultor'
Browse files Browse the repository at this point in the history
  • Loading branch information
@rultor
rultor committed Feb 26, 2018
2 parents 26b20a9 + 0148804 commit 582c085
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions src/main/resources/org/jpeek/metrics/LCC.xsl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,13 @@ SOFTWARE.
</xsl:for-each>
</xsl:variable>
<!--
@todo #9:30min `indirectly-related-pairs` are pairs of methods, which are through other directly connected methods.
https://pdfs.semanticscholar.org/672e/de6e3e600eafd84036a0b983b88e481ac626.pdf
Right now it is stubbed because information about method-method communication is yet to be provided in skeleton.xml
(issue #106).
@todo #119:30min `indirectly-related-pairs` are pairs of methods, which are connected through `directly-related-pairs`.
See section 3.1 of https://pdfs.semanticscholar.org/672e/de6e3e600eafd84036a0b983b88e481ac626.pdf
The key sentence is "The indirect connection relation is the **transitive closure** of direct connection relation".
See https://en.wikipedia.org/wiki/Transitive_closure for more info on what is a Transitive Closure.
We need to apply a Transitive Closure Algorithm on a graph of `directly-related-pairs`.
A simpliest Transitive Closure algorithms has O(V³) time complexity and involves a mutable V×V table (V is amount of vertices).
See https://www.geeksforgeeks.org/transitive-closure-of-a-graph/ for an example.
-->
<!--<xsl:variable name="indirectly-related-pairs">
</xsl:variable>
Expand Down

2 comments on commit 582c085

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 582c085 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 9-7a54dc2b disappeared from src/main/resources/org/jpeek/metrics/LCC.xsl, that's why I closed #119. Please, remember that the puzzle was not necessarily removed in this particular commit. Maybe it happened earlier, but we discovered this fact only now.

@0pdd
Copy link
Collaborator

@0pdd 0pdd commented on 582c085 Feb 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puzzle 119-5f1c56e0 discovered in src/main/resources/org/jpeek/metrics/LCC.xsl and submitted as #217. Please, remember that the puzzle was not necessarily added in this particular commit. Maybe it was added earlier, but we discovered it only now.

Please sign in to comment.