Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[108] eliminate tests skipping on windows #200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[108] eliminate tests skipping on windows #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe7d1b
[#108] remove skipping part of code
Jun 1, 2022
8aa77b8
[#108] fix commands for win
Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions test/test_pdd.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,9 @@ def test_rules_failure
end

def test_git_repo
skip if Gem.win_platform?
Dir.mktmpdir 'test' do |dir|
opts = opts(['-q', '-s', dir])
raise unless system("
set -e
cd '#{dir}'
git init --quiet .
git config user.email [email protected]
Expand Down
4 changes: 0 additions & 4 deletions test/test_source.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ def test_failing_on_puzzle_with_space_after_dash
end

def test_reads_git_author
skip if Gem.win_platform?
Dir.mktmpdir 'test' do |dir|
raise unless system("
set -e
Expand Down Expand Up @@ -255,7 +254,6 @@ def test_reads_git_author
end

def test_skips_invalid_git_mail
skip if Gem.win_platform?
Dir.mktmpdir 'test' do |dir|
raise unless system("
set -e
Expand Down Expand Up @@ -284,7 +282,6 @@ def test_skips_invalid_git_mail
end

def test_uses_github_login
skip if Gem.win_platform?
Dir.mktmpdir 'test' do |dir|
raise unless system("
cd '#{dir}'
Expand All @@ -306,7 +303,6 @@ def test_uses_github_login
end

def test_skips_uncommitted_changes
skip if Gem.win_platform?
Dir.mktmpdir 'test' do |dir|
raise unless system("
cd '#{dir}'
Expand Down