Use non-experimental pmr on newer clang versions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 (alias 15 on Apple platforms) finally completed the memory_resource header, and using the experimental version now triggers a 'deprecated declaration' warning.
steve-baker-cradle
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Could you update the README.md to reflect the availability of std::pmr in the different clang versions please.
It also looks like Xcode 15.0.1 is available on the new beta M1 Github runners - would now be a sensible time to run the tests (or at least check they compile) on those other platforms?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 16 (alias 15 on Apple platforms) finally completed the memory_resource header, and using the experimental version now triggers a 'deprecated declaration' warning.