-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pt 2136 progress bar does not trigger any screen reader status #16398
Open
gcamacho079
wants to merge
16
commits into
5.6
Choose a base branch
from
feature/pt-2136-progress-bar-does-not-trigger-any-screen-reader-status
base: 5.6
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/pt 2136 progress bar does not trigger any screen reader status #16398
gcamacho079
wants to merge
16
commits into
5.6
from
feature/pt-2136-progress-bar-does-not-trigger-any-screen-reader-status
+290
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar cache utility to use show/hide methods
…ear caches utility and db backup utility
…property in progress bar
gcamacho079
added
enhancement
improvements to existing features
accessibility 👤
features related to accessibility
labels
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
IntervalManager
class that can be used for managing JavaScript intervals. Includes methods for starting and stopping the interval.ProgressBar
has been updated so that announcements are made via anIntervalManager
instance. This allows screen reader users to get intermittent updates via theCraft.cp.announce()
method. This functionality can be disabled by settingannounceProgress
to false via the settings if live region updates will be handled elsewhere in the code.To test:
Related issues
Resolves PT-2136