Skip to content

Commit

Permalink
Update iframe notes (use cases, and infinite-loops)
Browse files Browse the repository at this point in the history
  • Loading branch information
craigfrancis committed May 15, 2019
1 parent 0583087 commit c99d4ed
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions problems/infinite-loops.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ But we *can* cheat here, as we don't need to consider every edge case that the "

We just need to let the browser do an initial layout, then it can **lock** the height, and use scroll bars as we do today.

Maybe we could also add a JavaScript method that the iframe content could call, asking for it's height to be updated (e.g. as more content loads/changes).
We *could* also add a JavaScript method the iframe content could call, asking for it's height to be updated, if the content changes.

Widget authors should be able to work within these constraints - like they do already, where they typically use `postMessage` and custom JavaScript in the parent to update the iframe height.
Widget authors already work within these constraints - where they typically use `postMessage` and custom JavaScript in the parent to update the iframe height.

---

Expand Down
2 changes: 1 addition & 1 deletion readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This was the main feature that `@seamless` needed to provide, rather than the `<

Suggested use cases:

- Adverts, where the parent page can provide the content via URL or postMessage.
- Adverts, where the parent page can provide the context via URL or postMessage.
- Comments on a blog, which you want to sandbox.
- Contact us form, on an otherwise static website.
- Subscribe to our mailing list.
Expand Down

0 comments on commit c99d4ed

Please sign in to comment.