Fix the **kern translation for figure 6 with a backslash #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Craig,
I tried to solve #15 by forking the repo and working on it. In this pull request, I managed to solve the second (small) problem of #15, which is "The slashed 6 is not translated properly (it should be
#6|
in **kern, not6\
)".However, for the first (main) problem of #15, which is "Figures under a stationary bass (mm.2 and mm.3) are partially missing", I found it pretty hard to fix. It seems to me that I need to change how figured bass is attached (currently, it seems to attach under each bass note, but there can be multiple figures associated with one bass note, and in these cases "musicxml2hum" won't work) in your code.
It will be great if you can help me with this, since I am working on adding figured bass to some of Bach's works (in musicXML) and trying to release it as a symbolic dataset for academic use in the near future, and I want to provide the **kern format as well (and MEI once the **kern version works). As you can see, "musicxml2hum" will be a really big help to this project.
Thank you in advance! Please let me know if there is any update in the future.
Cheers,
Yaolong