Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the **kern translation for figure 6 with a backslash #23

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

juyaolongpaul
Copy link
Contributor

Hi Craig,

I tried to solve #15 by forking the repo and working on it. In this pull request, I managed to solve the second (small) problem of #15, which is "The slashed 6 is not translated properly (it should be #6| in **kern, not 6\)".

However, for the first (main) problem of #15, which is "Figures under a stationary bass (mm.2 and mm.3) are partially missing", I found it pretty hard to fix. It seems to me that I need to change how figured bass is attached (currently, it seems to attach under each bass note, but there can be multiple figures associated with one bass note, and in these cases "musicxml2hum" won't work) in your code.

It will be great if you can help me with this, since I am working on adding figured bass to some of Bach's works (in musicXML) and trying to release it as a symbolic dataset for academic use in the near future, and I want to provide the **kern format as well (and MEI once the **kern version works). As you can see, "musicxml2hum" will be a really big help to this project.

Thank you in advance! Please let me know if there is any update in the future.

Cheers,
Yaolong

@craigsapp
Copy link
Owner

Looks good. Here are the target renderings for the slash types:

Screen Shot 2019-12-04 at 3 42 15 PM

But veorvio is missing the 6 with the large backslash which is the intended visualization of #6\. For the small slash on the top of the figure, I indent the encoding to be #6|.

Here is a page with a sampling of the initial conversion from MusicXML into Humdrum: humdrum-tools/verovio-humdrum-viewer#220

Screen Shot 2019-12-04 at 3 45 18 PM

Notice the box where the #6\ should have been displayed. So I think I might leave the MusicXML backslash element as \, but map the rendering of #6\ to match that of #6| when converting into MEI for now (until there is a rendering for #6\). If the #6| style is otherwise desired for #6\, then I can add an **fb interpretation to force #6\ to display as #6|.

@craigsapp craigsapp merged commit 67e0a59 into craigsapp:master Dec 4, 2019
@juyaolongpaul
Copy link
Contributor Author

Hi Craig,

Thanks for the detailed explanation. Recently I have used the Verovio command line to convert my **kern file with figured bass into MEI, and you are right, the problem of rendering #6\ is the only issue I have found out so far.

I think the #6| style works too (which is a bypass for the problem, and I agree with you that this essentially belongs to the Verivio rendering problem). Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants