Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes possible memory leak #24

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fixes possible memory leak #24

merged 2 commits into from
Dec 2, 2019

Conversation

valeriyvan
Copy link
Contributor

No description provided.

@craigsapp
Copy link
Owner

Looks good. The old code should never produce a memory leak, but your formulation is more clear and guarantees in the case of some strange change in the future that there remains no memory leak

@craigsapp craigsapp merged commit d877dc7 into craigsapp:master Dec 2, 2019
@valeriyvan
Copy link
Contributor Author

Looks good. The old code should never produce a memory leak, but your formulation is more clear and guarantees in the case of some strange change in the future that there remains no memory leak

Some diagnostic could be printed in if branch which should never fire normally.

@valeriyvan valeriyvan deleted the leak branch December 2, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valeriyvan @craigsapp