Implement --solfege option for deg tool #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You caught me copy-and-pasting :-) I set up the styling options so it is easy to add new stylings (such as --solf/--solfege) by copying another styling option's code in a few places. |
|
Yes, I could copy&paste the new option quite easily 😊. And since it’s already implemented in verovio it worked right away. Really cool! By the way, a colleague of mine has developed a font for hand symbols for solfège. I will check if these can be integrated. This will probably need SVG support for custom symbols in verovio. I will start a discussion on this when I get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that absolute solfège syllables are possible with
deg --solf --force-key C.I also fixed some outdated method name and parameters in the comments, as well as a wrong tandem interpretation for
*hat.