-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve option names #64
Conversation
Yes, I think it would be best to remove it because in the future, it might be useful to add a similar option to output only fb data without the score, but with some rhythmic information still available in
Yes, I think the problem is that the current VHV version of fb has |
You can give multiple aliases for an option, so it is good to have
What does the So you could have three aliases for the long form:
|
Okay, I removed it.
Exactly, but no idea why the site crashes. Probably something with the WASM. Does https://github.com/humdrum-tools/verovio-script need to be triggered to update it in VHV? Or is there a hook when
Okay, I readded it.
This sounds good. I added it as well. |
There is no automation in the update of VHV. The repository that would actually update automatically would be https://github.com/humdrum-tools/verovio-script (VHV loads the Humdrum-enabled version of verovio from that repository). This also applies to the Humdrum Notation Plugin repository https://github.com/humdrum-tools/humdrum-notation-plugin. So neither of those repositories deal directly with humlib or verovio, and they just load the WASM javascript file from the humdrum-tools/verovio-script repository. You could set it up to be automated 😉 That would be complicated because first humlimb need to be committed to the In the past I have preferred to monitor the compiling manually in case of some problem (but that rarely happens). |
I can setup a GitHub action and dockerize it if you want. It would be inside of https://github.com/humdrum-tools/verovio-script. The action can be configured to run regularly as a cronjob (let's say once a day or so) and additional it can be triggered manually. Have a look at this setup. This Dockerfile will create a custom verovio build (customized for my project in this case): This workflow will publish a docker image on ghcr.io: The image is now available on: This image then can be used in another action to run inside a docker container: But maybe this could even be simplified with a single GitHub workflow that runs directly inside a |
Reference: humdrum-tools/vhv-documentation#20