Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More improvements for option names #65

Merged
merged 5 commits into from
Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/humlib.h
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// Programmer: Craig Stuart Sapp <[email protected]>
// Creation Date: Sat Aug 8 12:24:49 PDT 2015
// Last Modified: Mo 23 Jan 2023 17:20:50 CET
// Last Modified: Mo 23 Jan 2023 17:51:36 CET
// Filename: humlib.h
// URL: https://github.com/craigsapp/humlib/blob/master/include/humlib.h
// Syntax: C++11
Expand Down Expand Up @@ -7302,7 +7302,7 @@ class Tool_fb : public HumTool {
bool m_sortQ = false;
bool m_lowestQ = false;
bool m_normalizeQ = false;
bool m_abbreviateQ = false;
bool m_reduceQ = false;
bool m_attackQ = false;
bool m_figuredbassQ = false;
bool m_hideThreeQ = false;
Expand Down
2 changes: 1 addition & 1 deletion include/tool-fb.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class Tool_fb : public HumTool {
bool m_sortQ = false;
bool m_lowestQ = false;
bool m_normalizeQ = false;
bool m_abbreviateQ = false;
bool m_reduceQ = false;
bool m_attackQ = false;
bool m_figuredbassQ = false;
bool m_hideThreeQ = false;
Expand Down
40 changes: 20 additions & 20 deletions src/humlib.cpp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
//
// Programmer: Craig Stuart Sapp <[email protected]>
// Creation Date: Sat Aug 8 12:24:49 PDT 2015
// Last Modified: Mo 23 Jan 2023 17:20:50 CET
// Last Modified: Mo 23 Jan 2023 17:51:36 CET
// Filename: /include/humlib.cpp
// URL: https://github.com/craigsapp/humlib/blob/master/src/humlib.cpp
// Syntax: C++11
Expand Down Expand Up @@ -78031,21 +78031,21 @@ void Tool_extract::initialize(HumdrumFile& infile) {
//

Tool_fb::Tool_fb(void) {
define("c|compound=b", "output reasonable figured bass numbers within octave");
define("a|accidentals=b", "display accidentals in figured bass output");
define("b|base|base-track=i:1", "number of the base kern track (compare with -k)");
define("i|intervallsatz=b", "display intervals under their voice and not under the lowest staff");
define("o|sort|order=b", "sort figured bass numbers by interval size and not by voice index");
define("l|lowest=b", "use lowest note as base note; -b flag will be ignored");
define("n|normalize=b", "remove octave and doubled intervals; adds: --compound --sort");
define("r|abbreviate=b", "use abbreviated figures; adds: --normalize --compound --sort");
define("t|ties=b", "hide repeated numbers for sustained notes when base does not change");
define("f|figuredbass=b", "shortcut for -c -a -o -n -r -3");
define("3|hide-three=b", "hide number 3 if it has an accidental (e.g.: #3 => #)");
define("m|negative=b", "show negative numbers");
define("above=b", "place figured bass numbers above staff (**fba)");
define("rate=s:", "rate to display the numbers (set a **recip value, e.g. 2, 4, 8, 4.)");
define("k|kern-tracks=s", "Process only the specified kern spines");
define("c|compound=b", "Output reasonable figured bass numbers within octave");
define("a|accidentals|accid|acc=b", "Display accidentals in front of the numbers");
define("b|base|base-track=i:1", "Number of the base kern track (compare with -k)");
define("i|intervallsatz=b", "Display numbers under their voice instead of under the base staff");
define("o|sort|order=b", "Sort figured bass numbers by size");
define("l|lowest=b", "Use lowest note as base note");
define("n|normalize=b", "Remove number 8 and doubled numbers; adds -co");
define("r|reduce|abbreviate|abbr=b", "Use abbreviated figures; adds -nco");
define("t|ties=b", "Hide numbers without attack or changing base (needs -i)");
define("f|figuredbass=b", "Shortcut for -acorn3");
define("3|hide-three=b", "Hide number 3 if it has an accidental");
define("m|negative=b", "Show negative numbers");
define("above=b", "Show numbers above the staff (**fba)");
define("rate=s:", "Rate to display the numbers (use a **recip value, e.g. 4, 4.)");
define("k|kern-tracks=s", "Process only the specified kern spines");
define("s|spine-tracks|spine|spines|track|tracks=s", "Process only the specified spines");
}

Expand Down Expand Up @@ -78106,7 +78106,7 @@ void Tool_fb::initialize(void) {
m_sortQ = getBoolean("sort");
m_lowestQ = getBoolean("lowest");
m_normalizeQ = getBoolean("normalize");
m_abbreviateQ = getBoolean("abbreviate");
m_reduceQ = getBoolean("reduce");
m_attackQ = getBoolean("ties");
m_figuredbassQ = getBoolean("figuredbass");
m_hideThreeQ = getBoolean("hide-three");
Expand All @@ -78125,14 +78125,14 @@ void Tool_fb::initialize(void) {
m_sortQ = true;
}

if (m_abbreviateQ) {
if (m_reduceQ) {
m_normalizeQ = true;
m_compoundQ = true;
m_sortQ = true;
}

if (m_figuredbassQ) {
m_abbreviateQ = true;
m_reduceQ = true;
m_normalizeQ = true;
m_compoundQ = true;
m_sortQ = true;
Expand Down Expand Up @@ -78634,7 +78634,7 @@ string Tool_fb::formatFiguredBassNumbers(const vector<FiguredBassNumber*>& numbe
});
}

if (m_abbreviateQ) {
if (m_reduceQ) {
// Overwrite formattedNumbers with abbreviated numbers
formattedNumbers = getAbbreviatedNumbers(formattedNumbers);
}
Expand Down
39 changes: 20 additions & 19 deletions src/tool-fb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// vim: syntax=cpp ts=3 noexpandtab nowrap
//
// Description: Add figured bass numbers from **kern spines.
// Documentation: https://doc.verovio.humdrum.org/filter/fb
//

#include "tool-fb.h"
Expand All @@ -27,21 +28,21 @@ namespace hum {
//

Tool_fb::Tool_fb(void) {
define("c|compound=b", "output reasonable figured bass numbers within octave");
define("a|accidentals=b", "display accidentals in figured bass output");
define("b|base|base-track=i:1", "number of the base kern track (compare with -k)");
define("i|intervallsatz=b", "display intervals under their voice and not under the lowest staff");
define("o|sort|order=b", "sort figured bass numbers by interval size and not by voice index");
define("l|lowest=b", "use lowest note as base note; -b flag will be ignored");
define("n|normalize=b", "remove octave and doubled intervals; adds: --compound --sort");
define("r|abbreviate=b", "use abbreviated figures; adds: --normalize --compound --sort");
define("t|ties=b", "hide repeated numbers for sustained notes when base does not change");
define("f|figuredbass=b", "shortcut for -c -a -o -n -r -3");
define("3|hide-three=b", "hide number 3 if it has an accidental (e.g.: #3 => #)");
define("m|negative=b", "show negative numbers");
define("above=b", "place figured bass numbers above staff (**fba)");
define("rate=s:", "rate to display the numbers (set a **recip value, e.g. 2, 4, 8, 4.)");
define("k|kern-tracks=s", "Process only the specified kern spines");
define("c|compound=b", "Output reasonable figured bass numbers within octave");
define("a|accidentals|accid|acc=b", "Display accidentals in front of the numbers");
define("b|base|base-track=i:1", "Number of the base kern track (compare with -k)");
define("i|intervallsatz=b", "Display numbers under their voice instead of under the base staff");
define("o|sort|order=b", "Sort figured bass numbers by size");
define("l|lowest=b", "Use lowest note as base note");
define("n|normalize=b", "Remove number 8 and doubled numbers; adds -co");
define("r|reduce|abbreviate|abbr=b", "Use abbreviated figures; adds -nco");
define("t|ties=b", "Hide numbers without attack or changing base (needs -i)");
define("f|figuredbass=b", "Shortcut for -acorn3");
define("3|hide-three=b", "Hide number 3 if it has an accidental");
define("m|negative=b", "Show negative numbers");
define("above=b", "Show numbers above the staff (**fba)");
define("rate=s:", "Rate to display the numbers (use a **recip value, e.g. 4, 4.)");
define("k|kern-tracks=s", "Process only the specified kern spines");
define("s|spine-tracks|spine|spines|track|tracks=s", "Process only the specified spines");
}

Expand Down Expand Up @@ -102,7 +103,7 @@ void Tool_fb::initialize(void) {
m_sortQ = getBoolean("sort");
m_lowestQ = getBoolean("lowest");
m_normalizeQ = getBoolean("normalize");
m_abbreviateQ = getBoolean("abbreviate");
m_reduceQ = getBoolean("reduce");
m_attackQ = getBoolean("ties");
m_figuredbassQ = getBoolean("figuredbass");
m_hideThreeQ = getBoolean("hide-three");
Expand All @@ -121,14 +122,14 @@ void Tool_fb::initialize(void) {
m_sortQ = true;
}

if (m_abbreviateQ) {
if (m_reduceQ) {
m_normalizeQ = true;
m_compoundQ = true;
m_sortQ = true;
}

if (m_figuredbassQ) {
m_abbreviateQ = true;
m_reduceQ = true;
m_normalizeQ = true;
m_compoundQ = true;
m_sortQ = true;
Expand Down Expand Up @@ -630,7 +631,7 @@ string Tool_fb::formatFiguredBassNumbers(const vector<FiguredBassNumber*>& numbe
});
}

if (m_abbreviateQ) {
if (m_reduceQ) {
// Overwrite formattedNumbers with abbreviated numbers
formattedNumbers = getAbbreviatedNumbers(formattedNumbers);
}
Expand Down