[musicxml2hum] Fix missing lines when nowevents includes nonzerodur elements #88
Conversation
WolfgangDrescher
changed the title
|
I debugged this further and it looks like there are two different problems. I use this file for debugging 004-p5-6-m5-7.xml.zip It looks like it's currently not possible to add figured bass numbers when there is no note in the bass. MuseScore also seems to have problems with this when I open the debugging file: 
Both Regardless of this the Expected: |
|
Never mind about the wrong order of the systems. This was caused by my import script to relocate the figured bass numbers from the upper to the lower system of piano 2… So the problems seems to be that I will have a look at this. |
|
I have improved the assignment of the figured bass numbers, but it is not perfect yet. I have created a few files that allow to debug this easier: fb-examples.zip Here is the current status for each example file: Example 0MuseScore
VHV (after) 
This is fine. But it's strange that Example 1MuseScore
I'm not sure why the figured bass numbers in the oboe are not displayed. I will keep debugging this. Example 2MuseScore
As there is only one Example 3MuseScore
Example 4MuseScore
Also here I think it is fine, that the Example 5MuseScore
Note that before there was a Example 6MuseScore
Notice the |
|
With 9d4510c the results are now much better. But example 6 is still failing though. Additionally I run the updated |
Add `vertical` and `back-slash` as possible values prefix and suffix https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/prefix/ https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/suffix/
|
I improved the detection for "slahed accidentals" by allowing This does comply with the specs in: Prefix should not contain // ...
} else if (suffix == "flat-flat") {
accidental = "--r";
} else if (suffix == "flat") {
accidental = "-r";
} else if (suffix == "double-sharp" || suffix == "sharp-sharp") {
accidental = "##r";
} else if (suffix == "sharp") {
accidental = "#r";
} else if (suffix == "natural") {
accidental = "nr";
}Why does the accidental include |
|
The 
|
If the part has no notes `addFiguredBass` has not been called and the m_current_figured_bass[partindex] have not been cleared
|
In b45e76d I removed adding Measures 4-5 before the change: After:
Measures 14-15 before the change After:
|
|
d309393 does improve the handling of cross staff layers (same voice number). If notes are generally in the lower staff but occasionally also appear in the upper staff this works fine as I can add the the total number of voices of the new staff to the current voice index (in case multiple layers change the staff). But is does not yet work well when notes that are generally in the upper staff but occasionally are pushed to the lower staff. The stems are wrong, because the voice should be the new voice index Do you have an idea how to solve this problem? Maybe using high voice indices such as
|
|
Here is a good encoding of the example (which may or may not be reflected in the data): 
**kern **kern
*clefF4 *clefG2
*M4/4 *M4/4
=1 =1
*^ *
4G 4C 4cc
4A 4C 4cc
4B 4C 4cc
4c> 4C 4cc
=2 =2 =2
4d> 4C 4cc
4e> 4C 4cc
4f> 4C 4cc
4g> 4C 4cc
*v *v *
== ==
*- *-
!!!RDF**kern: > = above |
|
7df2873 improves this behavior so that a voice (=same voice number) always has one staff to which it is assigned. If notes should be rendered in another staff than this "root staff" Is it okay to push this to humlib like this? I could add an option to |
Preserving voicing information as you are doing is better than changing the voice to the display staff. We will see what that does in the general case. Then perhaps So I should merge this PR now into humlib? |
|
Yes, I'm happy with it for now. Example 6 of fb-examples.zip – where ideally figured bass numbers should be combined from all voices and stacked – is still not perfect, but it's a special case which I don't need right now. So it's ready for review and to merge. I can implement it, when someone needs it. |
This PR fixes the missing data lines problem explained in #87.
However, it introduces a new bug. The parts and staves are now in the wrong order:
Expected:
Also note that the
**fbspine will be attached to the wrong part and staff now. Do you have any idea how to debug this further?Sourcefile: Schiorring - 04 Af dybeſte Nød raaber jeg til dig.mxl.zip
Screenshot of the output in VHV:
Click to see new output of musicxml2hum