SQLAlchemy: Fix handling URL parameters timeout and pool_size
#571
+59
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/sa-timeout-url-parameter
branch
2 times, most recently
from
d00a5fe to
294d23f
Compare
amotl
commented
Sep 5, 2023
amotl
force-pushed
the
amo/sa-timeout-url-parameter
branch
from
294d23f to
2d9a3f2
Compare
This was referenced Sep 29, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
While investigating #631/GH-570, we discovered that both the
timeoutandpool_sizeconfiguration settings failed being processed well, when obtaining them as URL parameters from the database connection string.This patch fixes that, and adds corresponding software tests and documentation.