Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter: Add very basic Rockset HTTP API emulation layer #183

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Jul 2, 2024

About

Because the Rockset HTTP API is sunsetting on September 30th, 2024, and CrateDB covers a reasonable amount of features, this is an experiment to wrap its features through a corresponding emulation layer, so client programs and libraries may work unmodified.

Documentation

Preview: https://cratedb-toolkit--183.org.readthedocs.build/adapter/rockset.html

References

@amotl amotl changed the title Adapter: Add Rockset HTTP API emulation layer Adapter: Add very basic Rockset HTTP API emulation layer Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 90.35088% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (4797dda) to head (2eec942).
Report is 4 commits behind head on main.

Files Patch % Lines
...ratedb_toolkit/adapter/rockset/server/api/query.py 83.33% 5 Missing ⚠️
cratedb_toolkit/util/database.py 63.63% 4 Missing ⚠️
cratedb_toolkit/adapter/rockset/cli.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   80.74%   81.17%   +0.43%     
==========================================
  Files          68       73       +5     
  Lines        2716     2826     +110     
==========================================
+ Hits         2193     2294     +101     
- Misses        523      532       +9     
Flag Coverage Δ
influxdb 37.57% <60.52%> (+0.94%) ⬆️
main 69.35% <90.35%> (+1.02%) ⬆️
mongodb 47.13% <60.52%> (+0.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl force-pushed the collab/rockset branch from f2d35a5 to 60454bd Compare July 2, 2024 09:02
Comment on lines 55 to 58
return {
"collections": [
"UNKNOWN",
],
Copy link
Member Author

@amotl amotl Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use cratedb-sqlparse 0.0.4 here, providing support to extract table name(s) from an SQL expression. Thanks, @surister.

Copy link
Member Author

@amotl amotl Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2eec942 brings in the corresponding improvement. It works well so far, and I am looking forward to further improvements. Cheers!

@amotl amotl force-pushed the collab/rockset branch from 60454bd to 2eec942 Compare July 2, 2024 21:30
@amotl amotl marked this pull request as ready for review July 5, 2024 22:47
@amotl amotl merged commit b590814 into main Jul 5, 2024
21 checks passed
@amotl amotl deleted the collab/rockset branch July 5, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant