-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter: Add very basic Rockset HTTP API emulation layer #183
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 80.74% 81.17% +0.43%
==========================================
Files 68 73 +5
Lines 2716 2826 +110
==========================================
+ Hits 2193 2294 +101
- Misses 523 532 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
return { | ||
"collections": [ | ||
"UNKNOWN", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use cratedb-sqlparse 0.0.4 here, providing support to extract table name(s) from an SQL expression. Thanks, @surister.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2eec942 brings in the corresponding improvement. It works well so far, and I am looking forward to further improvements. Cheers!
About
Because the Rockset HTTP API is sunsetting on September 30th, 2024, and CrateDB covers a reasonable amount of features, this is an experiment to wrap its features through a corresponding emulation layer, so client programs and libraries may work unmodified.
Documentation
Preview: https://cratedb-toolkit--183.org.readthedocs.build/adapter/rockset.html
References