Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks and fixes #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Some tweaks and fixes #2

wants to merge 4 commits into from

Conversation

Pipeliner
Copy link

No description provided.

perryprog added a commit to perryprog/crawl that referenced this pull request Feb 21, 2022
This commit soft-depends on:
- crawl/qw#2 for Depths being four levels deep
- crawl/qw#3 for armour switching behavior with the slot rename
- crawl/qw#4 for automatic ("streamlined") starting

This commit depends on crawl/qw#2 for Depths being four levels deep,
soft-depends on crawl/qw#3 for proper armour switching behavior due to
the slot rename, as well as crawl/qw#4 for automatic starting.
perryprog added a commit to perryprog/crawl that referenced this pull request Feb 21, 2022
This commit soft-depends on:
- crawl/qw#2 for Depths being four levels deep
- crawl/qw#3 for armour switching behavior with the slot rename
- crawl/qw#4 for automatic ("streamlined") starting

This commit depends on crawl/qw#2 for Depths being four levels deep,
soft-depends on crawl/qw#3 for proper armour switching behavior due to
the slot rename, as well as crawl/qw#4 for automatic starting.
perryprog added a commit to perryprog/crawl that referenced this pull request Feb 21, 2022
This commit soft-depends on:
- crawl/qw#2 for Depths being four levels deep
- crawl/qw#3 for armour switching behavior with the slot rename
- crawl/qw#4 for automatic ("streamlined") starting
gammafunk added a commit that referenced this pull request Jun 10, 2022
This updates fixes qw for 0.29 trunk with fixes from #2,
#3, and #5. It also has updates for the removal of Deep
Dwarves.

Code at or near the relevant changes has been re-indented as appropriate
for line length, but much work remains in that regard.

Closes #3. Closes #5.
@gammafunk
Copy link
Member

I merged a commit incorporating two of these fixes, thanks. For the other two, I'm not sure if they're a net improvement.

For berserking "red" monsters, from what I've seen we've always added monsters to the scary list manually more based on whether they tend to require it. I'm not sure if berserking red monsters always will in fact increase qw's winrate. The commit doesn't cite any detailed justification or data. Likewise for the cleaving/movement commit there's no justification given, and I'm not sure of all side-effects of those cleaving changes given that they modify multiple plan-related functions.

I do now have a setup to run qw continuously now on a test server, but I don't yet have any stat tracking as of yet. Once I set up some stat tracking and also get a sense of what the better qw combos are for 0.29 now that Deep Dwarves are removed, I can try out these commits. Hence I'll keep this PR open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants