Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dac 524 baseline v2, v3, NLU demo #21

Merged
merged 37 commits into from
Dec 12, 2023
Merged

Dac 524 baseline v2, v3, NLU demo #21

merged 37 commits into from
Dec 12, 2023

Conversation

TimeaBagosiCrim
Copy link
Contributor

final NLU module containing V1, V2, V3, Demo notebook, evaluation, stac handler, etc.

@TimeaBagosiCrim TimeaBagosiCrim changed the title Dac 524 baseline v2 Dac 524 baseline v2, v3, NLU demo Nov 30, 2023
@TimeaBagosiCrim
Copy link
Contributor Author

new requirements to be added
it needs a Docker service to be run: rasa/duckling on port 8000
it needs prop_vdb and target_vdb directories (committed here but can be rolled back if placed somewhere else)
question: absolute paths in many files, replace them with what?

Copy link
Contributor

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the files are provided as demo samples, all JSON contents should probably be reformatted with newlines to make them more readable
(can use cat "<file.json>" | jq > "<file.json>" to indent them).

nlp/notebooks/nl2q_eval/MetricsClasses.py Outdated Show resolved Hide resolved
nlp/notebooks/nl2q_eval/ceda_gold_queries.json Outdated Show resolved Hide resolved
nlp/notebooks/nl2q_eval/clean_annotations.py Outdated Show resolved Hide resolved
nlp/notebooks/nl2q_eval/clean_annotations.py Outdated Show resolved Hide resolved
nlp/notebooks/nl2q_eval/clean_annotations.py Outdated Show resolved Hide resolved
nlp/notebooks/NLU_demo.ipynb Outdated Show resolved Hide resolved
nlp/notebooks/nl2query/V2/requirements.txt Outdated Show resolved Hide resolved
nlp/notebooks/stac_wrapper/stac_config.cfg Outdated Show resolved Hide resolved
nlp/notebooks/stac_wrapper/stac_config.cfg Outdated Show resolved Hide resolved
nlp/notebooks/stac_wrapper/stac_config.cfg Outdated Show resolved Hide resolved
@fmigneault
Copy link
Contributor

@TimeaBagosiCrim
If added a new way to call duckling that does not require the docker image in 0d93ef7. It uses a pre-installed binary instead.

I found a few places where V2 pipeline was broken with missing VDB instance references.
After fixing those, I reached a point where V3 pipeline tries to obtain spans from V2 pipeline, which always causes an error.
This can be seen in https://github.com/crim-ca/pavics-jupyter-images/blob/DAC-524-baseline-V2/nlp/notebooks/NLU_demo.ipynb
Do you have an idea on how this can be fixed?

@fmigneault fmigneault merged commit aae8dd4 into master Dec 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants