Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping crossplane provider with TF v0.22.1 #39

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

SivaanandM
Copy link
Collaborator

@SivaanandM SivaanandM commented Dec 16, 2024

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@SivaanandM
Copy link
Collaborator Author

@TylerGillson I tried remove .work directory and run make generate still check-diff is failing. not able to reproduce it in local
Screenshot 2024-12-16 at 11 47 04 AM

SivaanandM and others added 3 commits December 16, 2024 15:59
@TylerGillson
Copy link
Collaborator

@SivaanandM I fixed your DCO, deleted .work locally, ran make reviewable, and uploaded the diff.

I was getting lint failures locally, but I just ignored them and the failure isn't happening in CI 🤷🏼‍♂️

@TylerGillson TylerGillson merged commit 8d2a404 into main Dec 16, 2024
9 checks passed
@TylerGillson TylerGillson deleted the tf-v0.22.1 branch December 16, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants