Add options for skipping default tags #1474
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikael-lindstrom
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
Signed-off-by: Mikael Lindström <[email protected]>
mikael-lindstrom
force-pushed
the
optional-default-tags
branch
from
6fe2478 to
f14d9f8
Compare
|
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
|
This pull request is being closed since there has been no activity for 14 days since marking it as |
|
/reopen |
|
Would really like this feature, as the "S3-compatible" Cloudian also does not support tags on IAM Policy and User. |
|
If it's not possible to get this option into the provider config without severe drawbacks, it LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The PR introduces the argument
--skip-default-tagswhich makes the provider skip setting the default tags:This is useful for "S3-compatible" services such as Scality Ring which implements all the required API for Crossplane except for tags. Currently the provider fails to create a bucket in Scality Ring since the tag API returns
501 NotImplemented.Unfortunately this introduces changes to a lot of generated files since
hack/main.go.tmplis modified but the change is small. Unsure if there is a better way to solve this.Fixes #1141
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This has been tested against localstack and works as previously without
--skip-default-tags, when it's set it correctly skips setting the default crossplane tags for S3 buckets.We are running this change in production for a week now and it's working fine with the option
--skip-default-tagsadded to theDeploymentRuntimeConfigagainst Scality Ring which does not support tags.