[cscli] notifications test command and slight re write

[LaurenceJJones]

Rework some of the cscli notification stuff

• Add a generic test which works with active and non active configurations
• Split the top function so can reuse some code 😄
• Found an issue which notification configuration were not set the default max retry so if it failed the first time then it would just exit rather than retrying which is crowdsec natural configuration. Had to expose the func as it was private before

[github-actions]

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[LaurenceJJones]

/kind enhancement
/area cscli

[codecov]

Codecov Report

Merging #2391 (bde8dbc) into master (ff7acd3) will decrease coverage by 0.09%.
The diff coverage is 22.46%.

@@            Coverage Diff             @@
##           master    #2391      +/-   ##
==========================================
- Coverage   57.24%   57.15%   -0.09%     
==========================================
  Files         189      189              
  Lines       26100    26176      +76     
==========================================
+ Hits        14941    14961      +20     
- Misses       9586     9640      +54     
- Partials     1573     1575       +2     

Flag	Coverage Δ
bats	38.94% <22.46%> (-0.05%)	⬇️
unit-linux	55.17% <100.00%> (+0.07%)	⬆️
unit-windows	51.72% <100.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/csplugin/broker.go	78.18% <100.00%> (ø)
cmd/crowdsec-cli/notifications.go	29.00% <21.32%> (-0.41%)	⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[LaurenceJJones]

Assign @sabban to review upon return

[sabban]

lgtm