Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refact bouncer auth #2456

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Refact bouncer auth #2456

merged 5 commits into from
Dec 4, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 7, 2023 •
edited
Loading

Cleanup and code de-duplication

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added this to the 1.5.4 milestone Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added kind/enhancement New feature or request area/local-api labels Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (d1bfadd) 58.08% compared to head (a1cc550) 58.27%.

Files Patch % Lines
pkg/apiserver/middlewares/v1/api_key.go 31.70% 54 Missing and 2 partials ⚠️
pkg/apiserver/apiserver.go 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2456      +/-   ##
==========================================
+ Coverage   58.08%   58.27%   +0.18%     
==========================================
  Files         197      201       +4     
  Lines       26707    27042     +335     
==========================================
+ Hits        15514    15758     +244     
- Misses       9675     9732      +57     
- Partials     1518     1552      +34
Flag Coverage Δ
bats 38.41% <20.22%> (+0.08%) ⬆️
unit-linux 55.38% <31.46%> (+0.14%) ⬆️
unit-windows 51.56% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc modified the milestones: 1.5.4, 1.5.5 Sep 19, 2023
@mmetc mmetc force-pushed the refact-bouncer-auth branch 2 times, most recently from 32647f3 to c915f67 Compare October 2, 2023 15:18
@mmetc mmetc removed this from the 1.5.5 milestone Oct 3, 2023
@mmetc mmetc force-pushed the refact-bouncer-auth branch from c915f67 to 007e58e Compare October 9, 2023 21:32
@mmetc mmetc force-pushed the refact-bouncer-auth branch from 007e58e to 9b7c522 Compare November 7, 2023 13:24
@mmetc mmetc marked this pull request as draft November 7, 2023 13:26
@mmetc mmetc force-pushed the refact-bouncer-auth branch from 9b7c522 to 7e32b11 Compare November 7, 2023 13:28
@mmetc mmetc marked this pull request as ready for review November 7, 2023 13:30
@mmetc mmetc added this to the 1.5.6 milestone Nov 7, 2023
@mmetc mmetc requested a review from blotus November 10, 2023 13:35
@mmetc mmetc force-pushed the refact-bouncer-auth branch from 7e32b11 to b306b47 Compare November 16, 2023 12:27
mmetc added 4 commits November 29, 2023 17:32
@mmetc
refact middleware, duplicate code
f7fdb6b
@mmetc
remove empty error from wrap chain
c309383
@mmetc
reduce log verbosity
dd6c819 
replace this:

ERRO[07-09-2023 16:51:19] while fetching bouncer info: select bouncer: ent: bouncer not found: unable to query  ip=127.0.0.1

with this:

ERRO[07-09-2023 17:03:19] while fetching bouncer info: ent: bouncer not found  ip=127.0.0.1
@mmetc
in case of error, return nil pointer instead of pointer to zero value
55b86d8
@mmetc mmetc force-pushed the refact-bouncer-auth branch from 3e3aa66 to 55b86d8 Compare November 29, 2023 16:33
@mmetc mmetc merged commit 23968e4 into master Dec 4, 2023
13 checks passed
@mmetc mmetc deleted the refact-bouncer-auth branch December 4, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blotus blotus blotus approved these changes

Assignees

@blotus blotus

Labels
area/local-api kind/enhancement New feature or request
Projects
None yet
Milestone
1.5.6
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @blotus