Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos/grammar #2561

Merged
merged 1 commit into from
Nov 7, 2023
Merged

typos/grammar #2561

merged 1 commit into from
Nov 7, 2023

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Oct 24, 2023

No description provided.

@github-actions
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #2561 (57972ee) into master (272cf54) will decrease coverage by 0.23%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

❗ Current head 57972ee differs from pull request most recent head 4ebf80d. Consider uploading reports for the commit 4ebf80d to get more accurate results

@@            Coverage Diff             @@
##           master    #2561      +/-   ##
==========================================
- Coverage   57.16%   56.93%   -0.23%     
==========================================
  Files         190      190              
  Lines       26156    26156              
==========================================
- Hits        14953    14893      -60     
- Misses       9633     9705      +72     
+ Partials     1570     1558      -12     
Flag Coverage Δ
bats 38.64% <50.00%> (-0.24%) ⬇️
unit-linux 55.20% <33.33%> (+0.02%) ⬆️
unit-windows 51.78% <33.33%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/crowdsec-cli/dashboard.go 28.43% <ø> (ø)
pkg/apiserver/apic.go 69.53% <ø> (ø)
pkg/csconfig/config.go 100.00% <ø> (ø)
pkg/csplugin/broker.go 78.18% <100.00%> (ø)
pkg/metabase/api.go 0.00% <ø> (ø)
cmd/crowdsec-cli/config_backup.go 52.63% <0.00%> (ø)
pkg/leakybucket/bucket.go 85.34% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 5cd4406 into master Nov 7, 2023
10 of 11 checks passed
@mmetc mmetc deleted the grammar branch November 7, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants