Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add option to fetch only given blocklists #2590

Closed
wants to merge 5 commits into from

Conversation

nitescuc
Copy link
Contributor

No description provided.

Copy link

@nitescuc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@nitescuc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@nitescuc nitescuc added the kind/enhancement New feature or request label Nov 14, 2023
@nitescuc nitescuc force-pushed the blocklists_only_force_pull branch from fac8651 to 61e039d Compare November 22, 2023 13:43
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 234 lines in your changes are missing coverage. Please review.

Comparison is base (ddd6ee8) 57.24% compared to head (965d149) 56.96%.
Report is 7 commits behind head on master.

Files Patch % Lines
...on/modules/loki/internal/lokiclient/loki_client.go 51.62% 93 Missing and 11 partials ⚠️
pkg/acquisition/modules/loki/loki.go 72.06% 56 Missing and 13 partials ⚠️
pkg/apiserver/papi_cmd.go 0.00% 19 Missing ⚠️
pkg/apiserver/apic.go 57.50% 8 Missing and 9 partials ⚠️
pkg/acquisition/modules/loki/entry.go 0.00% 13 Missing ⚠️
...uisition/modules/loki/internal/lokiclient/types.go 53.84% 4 Missing and 2 partials ⚠️
pkg/acquisition/modules/kafka/kafka.go 88.00% 1 Missing and 2 partials ⚠️
pkg/acquisition/modules/loki/timestamp.go 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2590      +/-   ##
==========================================
- Coverage   57.24%   56.96%   -0.29%     
==========================================
  Files         190      195       +5     
  Lines       26156    26707     +551     
==========================================
+ Hits        14974    15214     +240     
- Misses       9605     9912     +307     
- Partials     1577     1581       +4     
Flag Coverage Δ
bats 37.77% <2.53%> (-1.17%) ⬇️
unit-linux 55.38% <60.47%> (+0.20%) ⬆️
unit-windows 51.77% <46.97%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nitescuc nitescuc changed the title WIP: add option to fetch only given blocklists add option to fetch only given blocklists Nov 23, 2023
@nitescuc nitescuc changed the title add option to fetch only given blocklists WIP: add option to fetch only given blocklists Nov 23, 2023
@nitescuc nitescuc closed this Nov 24, 2023
@nitescuc nitescuc deleted the blocklists_only_force_pull branch November 24, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants