Refact cwhub: simplify tree scan and dependency checks

[mmetc]

No description provided.

[github-actions]

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

• /kind feature
• /kind enhancement
• /kind fix
• /kind chore
• /kind dependencies

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (56ad2bb) 57.46% compared to head (f50b65b) 57.52%.

Files	Patch %	Lines
pkg/cwhub/sync.go	74.35%	28 Missing and 2 partials ⚠️
pkg/cwhub/helpers.go	75.00%	4 Missing and 5 partials ⚠️
pkg/cwhub/hub.go	76.92%	2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/console.go	0.00%	1 Missing ⚠️
cmd/crowdsec-cli/item_suggest.go	0.00%	1 Missing ⚠️
cmd/crowdsec/output.go	50.00%	0 Missing and 1 partial ⚠️
pkg/cwhub/enable.go	75.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           hub-1.5.6    #2600      +/-   ##
=============================================
+ Coverage      57.46%   57.52%   +0.06%     
=============================================
  Files            193      193              
  Lines          25945    25970      +25     
=============================================
+ Hits           14908    14939      +31     
+ Misses          9520     9516       -4     
+ Partials        1517     1515       -2     

Flag	Coverage Δ
bats	39.12% <71.66%> (+0.05%)	⬆️
unit-linux	54.62% <61.27%> (-0.06%)	⬇️
unit-windows	51.22% <61.27%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sabban]

lgtm