Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context propagation: pkg/database/metrics #3247

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pkg/apiserver/apic_metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
}

for _, bouncer := range bouncers {
dbMetrics, err := a.dbClient.GetBouncerUsageMetricsByName(bouncer.Name)
dbMetrics, err := a.dbClient.GetBouncerUsageMetricsByName(ctx, bouncer.Name)

Check warning on line 41 in pkg/apiserver/apic_metrics.go

View check run for this annotation

Codecov / codecov/patch

pkg/apiserver/apic_metrics.go#L41

Added line #L41 was not covered by tests
if err != nil {
log.Errorf("unable to get bouncer usage metrics: %s", err)
continue
Expand Down Expand Up @@ -81,7 +81,7 @@
}

for _, lp := range lps {
dbMetrics, err := a.dbClient.GetLPUsageMetricsByMachineID(lp.MachineId)
dbMetrics, err := a.dbClient.GetLPUsageMetricsByMachineID(ctx, lp.MachineId)

Check warning on line 84 in pkg/apiserver/apic_metrics.go

View check run for this annotation

Codecov / codecov/patch

pkg/apiserver/apic_metrics.go#L84

Added line #L84 was not covered by tests
if err != nil {
log.Errorf("unable to get LP usage metrics: %s", err)
continue
Expand Down Expand Up @@ -181,8 +181,8 @@
return allMetrics, metricsIds, nil
}

func (a *apic) MarkUsageMetricsAsSent(ids []int) error {
return a.dbClient.MarkUsageMetricsAsSent(ids)
func (a *apic) MarkUsageMetricsAsSent(ctx context.Context, ids []int) error {
return a.dbClient.MarkUsageMetricsAsSent(ctx, ids)

Check warning on line 185 in pkg/apiserver/apic_metrics.go

View check run for this annotation

Codecov / codecov/patch

pkg/apiserver/apic_metrics.go#L184-L185

Added lines #L184 - L185 were not covered by tests
}

func (a *apic) GetMetrics(ctx context.Context) (*models.Metrics, error) {
Expand Down Expand Up @@ -379,7 +379,7 @@
}
}

err = a.MarkUsageMetricsAsSent(metricsId)
err = a.MarkUsageMetricsAsSent(ctx, metricsId)

Check warning on line 382 in pkg/apiserver/apic_metrics.go

View check run for this annotation

Codecov / codecov/patch

pkg/apiserver/apic_metrics.go#L382

Added line #L382 was not covered by tests
if err != nil {
log.Errorf("unable to mark usage metrics as sent: %s", err)
continue
Expand Down
8 changes: 6 additions & 2 deletions pkg/apiserver/usage_metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import (
)

func TestLPMetrics(t *testing.T) {
ctx := context.Background()

tests := []struct {
name string
body string
Expand Down Expand Up @@ -198,7 +200,7 @@ func TestLPMetrics(t *testing.T) {
assert.Contains(t, w.Body.String(), tt.expectedResponse)

machine, _ := dbClient.QueryMachineByID("test")
metrics, _ := dbClient.GetLPUsageMetricsByMachineID("test")
metrics, _ := dbClient.GetLPUsageMetricsByMachineID(ctx, "test")

assert.Len(t, metrics, tt.expectedMetricsCount)
assert.Equal(t, tt.expectedOSName, machine.Osname)
Expand All @@ -214,6 +216,8 @@ func TestLPMetrics(t *testing.T) {
}

func TestRCMetrics(t *testing.T) {
ctx := context.Background()

tests := []struct {
name string
body string
Expand Down Expand Up @@ -368,7 +372,7 @@ func TestRCMetrics(t *testing.T) {
assert.Contains(t, w.Body.String(), tt.expectedResponse)

bouncer, _ := dbClient.SelectBouncerByName("test")
metrics, _ := dbClient.GetBouncerUsageMetricsByName("test")
metrics, _ := dbClient.GetBouncerUsageMetricsByName(ctx, "test")

assert.Len(t, metrics, tt.expectedMetricsCount)
assert.Equal(t, tt.expectedOSName, bouncer.Osname)
Expand Down
12 changes: 6 additions & 6 deletions pkg/database/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@
return metric, nil
}

func (c *Client) GetLPUsageMetricsByMachineID(machineId string) ([]*ent.Metric, error) {
func (c *Client) GetLPUsageMetricsByMachineID(ctx context.Context, machineId string) ([]*ent.Metric, error) {
metrics, err := c.Ent.Metric.Query().
Where(
metric.GeneratedTypeEQ(metric.GeneratedTypeLP),
metric.GeneratedByEQ(machineId),
metric.PushedAtIsNil(),
).
All(c.CTX)
All(ctx)
if err != nil {
c.Log.Warningf("GetLPUsageMetricsByOrigin: %s", err)
return nil, fmt.Errorf("getting LP usage metrics by origin %s: %w", machineId, err)
Expand All @@ -41,14 +41,14 @@
return metrics, nil
}

func (c *Client) GetBouncerUsageMetricsByName(bouncerName string) ([]*ent.Metric, error) {
func (c *Client) GetBouncerUsageMetricsByName(ctx context.Context, bouncerName string) ([]*ent.Metric, error) {
metrics, err := c.Ent.Metric.Query().
Where(
metric.GeneratedTypeEQ(metric.GeneratedTypeRC),
metric.GeneratedByEQ(bouncerName),
metric.PushedAtIsNil(),
).
All(c.CTX)
All(ctx)
if err != nil {
c.Log.Warningf("GetBouncerUsageMetricsByName: %s", err)
return nil, fmt.Errorf("getting bouncer usage metrics by name %s: %w", bouncerName, err)
Expand All @@ -57,11 +57,11 @@
return metrics, nil
}

func (c *Client) MarkUsageMetricsAsSent(ids []int) error {
func (c *Client) MarkUsageMetricsAsSent(ctx context.Context, ids []int) error {

Check warning on line 60 in pkg/database/metrics.go

View check run for this annotation

Codecov / codecov/patch

pkg/database/metrics.go#L60

Added line #L60 was not covered by tests
_, err := c.Ent.Metric.Update().
Where(metric.IDIn(ids...)).
SetPushedAt(time.Now().UTC()).
Save(c.CTX)
Save(ctx)

Check warning on line 64 in pkg/database/metrics.go

View check run for this annotation

Codecov / codecov/patch

pkg/database/metrics.go#L64

Added line #L64 was not covered by tests
if err != nil {
c.Log.Warningf("MarkUsageMetricsAsSent: %s", err)
return fmt.Errorf("marking usage metrics as sent: %w", err)
Expand Down