Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint/deep-exit: avoid log.Fatal #3360

Merged
merged 4 commits into from
Dec 13, 2024

lint

78d659a
Select commit
Loading
Failed to load commit list.
Merged

lint/deep-exit: avoid log.Fatal #3360

lint
78d659a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 13, 2024 in 1s

58.40% (target 0.00%)

View this Pull Request on Codecov

58.40% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 33.80282% with 47 lines in your changes missing coverage. Please review.

Project coverage is 58.40%. Comparing base (08296d9) to head (78d659a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clihub/item_metrics.go 34.88% 22 Missing and 6 partials ⚠️
cmd/crowdsec-cli/dashboard.go 0.00% 5 Missing ⚠️
cmd/crowdsec-cli/clicapi/capi.go 40.00% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/clilapi/register.go 40.00% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/climachine/add.go 25.00% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/idgen/machineid.go 40.00% 2 Missing and 1 partial ⚠️
cmd/crowdsec-cli/idgen/password.go 66.66% 1 Missing ⚠️
pkg/leakybucket/overflows.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3360      +/-   ##
==========================================
- Coverage   58.44%   58.40%   -0.04%     
==========================================
  Files         351      351              
  Lines       37825    37867      +42     
==========================================
+ Hits        22105    22115      +10     
- Misses      13816    13841      +25     
- Partials     1904     1911       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov