Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint/deep-exit: avoid log.Fatal #3367

Merged
merged 7 commits into from
Dec 18, 2024
Merged

lint/deep-exit: avoid log.Fatal #3367

merged 7 commits into from
Dec 18, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 16, 2024

lint/deep-exit: client_test.go
lint/deep-exit: parsing_test.go
lint/deep-exit: watcher_test.go
lint/deep-exit: kinesis_test.go
lint/deep-exit: don't fail on invalid alert

@mmetc mmetc added this to the 1.6.5 milestone Dec 16, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.40%. Comparing base (b1e2b95) to head (bd3c61d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/leakybucket/overflows.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3367      +/-   ##
==========================================
- Coverage   58.40%   58.40%   -0.01%     
==========================================
  Files         351      351              
  Lines       37879    37876       -3     
==========================================
- Hits        22125    22120       -5     
  Misses      13843    13843              
- Partials     1911     1913       +2     
Flag Coverage Δ
bats 41.27% <0.00%> (+<0.01%) ⬆️
unit-linux 34.38% <50.00%> (-0.01%) ⬇️
unit-windows 29.60% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit ecf34c2 into master Dec 18, 2024
17 checks passed
@mmetc mmetc deleted the deep-exit branch December 18, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants