Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor pkg/leakybucket #3371

Merged
merged 5 commits into from
Dec 20, 2024
Merged

refactor pkg/leakybucket #3371

merged 5 commits into from
Dec 20, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Dec 18, 2024

filter is

  • disallowed for scope=ip (or empty)
  • optional for scope=range
  • required otherwise

@mmetc mmetc added this to the 1.6.5 milestone Dec 18, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 12 lines in your changes missing coverage. Please review.

Project coverage is 58.48%. Comparing base (26c15a1) to head (0f7e199).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/leakybucket/manager_load.go 63.63% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3371   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files         352      352           
  Lines       37871    37859   -12     
=======================================
- Hits        22148    22141    -7     
+ Misses      13815    13809    -6     
- Partials     1908     1909    +1     
Flag Coverage Δ
bats 41.33% <60.52%> (+0.01%) ⬆️
unit-linux 34.44% <50.00%> (+<0.01%) ⬆️
unit-windows 29.69% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc marked this pull request as ready for review December 18, 2024 11:12
@buixor buixor added the value/high Doing this significantly improves some areas label Dec 18, 2024
@mmetc mmetc merged commit 4748720 into master Dec 20, 2024
17 checks passed
@mmetc mmetc deleted the loadbuckets branch December 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactoring needs/area value/high Doing this significantly improves some areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants