Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add a connection test to explain to add '-no-api' flag #3385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LaurenceJJones
Copy link
Contributor

as outlined in #3183 you cannot run explain whilst LAPI is not available, this PR adds a connection test to explain and if the connection succeeds, the -no-api flag is then appended to the cmd arguments.

Copy link

@LaurenceJJones: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@LaurenceJJones: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor Author

/kind enhancement
/area cscli

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (5c0c4f9) to head (1312244).

Files with missing lines Patch % Lines
cmd/crowdsec-cli/cliexplain/explain.go 44.00% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
- Coverage   58.63%   58.60%   -0.03%     
==========================================
  Files         356      356              
  Lines       38215    38237      +22     
==========================================
+ Hits        22406    22410       +4     
- Misses      13895    13910      +15     
- Partials     1914     1917       +3     
Flag Coverage Δ
bats 41.58% <44.00%> (-0.06%) ⬇️
unit-linux 33.09% <0.00%> (-0.03%) ⬇️
unit-windows 28.39% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cscli kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant