Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gin: do not use gin context after returning response #3398

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

blotus
Copy link
Member

@blotus blotus commented Jan 10, 2025

Fixes #3338

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Jan 10, 2025

/kind fix
/area local-api

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.10%. Comparing base (34c0e6a) to head (8ad37bd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiserver/controllers/v1/decisions.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3398      +/-   ##
==========================================
+ Coverage   59.09%   59.10%   +0.01%     
==========================================
  Files         359      359              
  Lines       38654    38653       -1     
==========================================
+ Hits        22842    22847       +5     
+ Misses      13890    13885       -5     
+ Partials     1922     1921       -1     
Flag Coverage Δ
bats 42.24% <50.00%> (+0.01%) ⬆️
unit-linux 32.81% <50.00%> (+<0.01%) ⬆️
unit-windows 28.19% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus merged commit 303ce8e into master Jan 10, 2025
17 checks passed
@blotus blotus deleted the context-rollback-bouncer-last-pull branch January 10, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.6.4] Investigate unable to update bouncer 'X'
2 participants