Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JA4H expr helper #3401

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add JA4H expr helper #3401

wants to merge 5 commits into from

Conversation

blotus
Copy link
Member

@blotus blotus commented Jan 15, 2025

No description provided.

@blotus blotus marked this pull request as draft January 15, 2025 15:17
Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Jan 15, 2025

/kind enhancement
/area appsec

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.36%. Comparing base (62308f5) to head (9246c66).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/appsec/ja4h/ja4h.go 82.79% 12 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3401      +/-   ##
==========================================
+ Coverage   59.30%   59.36%   +0.06%     
==========================================
  Files         358      360       +2     
  Lines       38425    38521      +96     
==========================================
+ Hits        22788    22869      +81     
- Misses      13742    13754      +12     
- Partials     1895     1898       +3     
Flag Coverage Δ
bats 42.11% <0.00%> (-0.14%) ⬇️
unit-linux 33.33% <83.33%> (+0.13%) ⬆️
unit-windows 28.62% <83.33%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blotus blotus added this to the 1.6.5 milestone Jan 17, 2025
@buixor buixor self-requested a review January 24, 2025 13:01
@LaurenceJJones LaurenceJJones marked this pull request as ready for review January 24, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/appsec kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants