Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(links): fix Breadcrumb links and improve CryostatLink #1545

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jan 30, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Description of the change:

Updates the TargetContextSelector and NotFound components to use the CryostatLink intsead of Link, to properly route when using a basepath.

Updates the CryostatLink to optionally handle onClick, so it can be used in a couple more areas.

Fixes the breadcrumb links to just simply use , because the incoming routes already have a basepath prepended they do not have to use (it's added twice).

Motivation for the change:

Clicking around the console plugin I ran into a 404 on the TargetContextSelector because it was routing to '/topology/create-custom-target' instead of '/cryostat/topology/create-custom-target'. This PR updates that usage, as well as remaining areas involved with Links.

@andrewazores andrewazores merged commit 9673633 into cryostatio:main Jan 30, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants