Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(links): update CryostatLink to handle partial paths (backport #1567) #1568

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Feb 10, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: #144

Description of the change:

The links in the Topology EntityDetails were not using CryostatLink, so any basepath was not being prepended to the pathname.

However, those links make use of To from LinkProps, which CryostatLink did not previously handle.

CryostatLink now handles incoming paths that are of types string | partial.

Motivation for the change:

Fixes the links on the Topology page.


This is an automatic backport of pull request #1567 done by [Mergify](https://mergify.com).

@mergify mergify bot assigned aptmac Feb 10, 2025
Copy link

Hi @mergify[bot]! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@andrewazores andrewazores merged commit 4ee44c4 into cryostat-v4.0 Feb 10, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants