feat(recordings): implement PATCH recordingOptions #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
patch-itest
branch
from
619ad1c to
1302588
Compare
|
/build_test |
|
Workflow started at 11/22/2023, 2:15:29 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
|
CI build and push: At least one test failed ❌ |
|
Not ready yet - looks like this is pretty flakey, or rather, it's interacting badly with other tests. |
andrewazores
force-pushed
the
patch-itest
branch
from
fb39a5f to
a5516b9
Compare
andrewazores
force-pushed
the
patch-itest
branch
from
a5516b9 to
adae0ef
Compare
7 tasks
andrewazores
force-pushed
the
patch-itest
branch
from
f0eca15 to
a178642
Compare
|
/build_test |
|
This PR/issue depends on:
|
|
Workflow started at 11/27/2023, 12:42:45 PM. View Actions Run. |
|
CI build and push: All tests pass ✅ |
3 tasks
|
CI build and push: All tests pass ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainRelated to #122
See #184
See #42
Depends on #185
Description of the change:
Reimplements PATCH for
recordingOptionsand re-enables the related test.This is not actually used in the UI anywhere and is a bit of a questionable feature - this was originally implemented to allow the user to specify default recording options (maxAge, maxSize, toDisk) that would apply to every recording they would create. It's one of the very first functionalities implemented in the original cli container-jfr project and dates back to when the user would need to choose an individual target to connect to, choose whether to set these options, then invoke recording creation upon the connected target using those options. This operation doesn't properly account for the newer "connectionless" HTTP API system either, so despite the request URL containing a
connectUrlpath param, these options are actually set globally for the whole server instance on any target.See #184 . This is a direct port of the implementation from 2.4 which has the issues outlined above. We should decide if this feature should be dropped from the API altogether, or if it makes sense to "modernize" it and find a way to make use of it in the UI.
How to manually test:
You could use curl/HTTPie to test the endpoint manually, but I'm not sure the value.